Page MenuHomePhabricator
Create Task
Maniphest T275546

Wikimedia OCR: Add Symfony
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As a Wikisource user, I want Symfony added to Wikimedia OCR so that the OCR tool can be maintained and improved in a more sustainable and up-to-date manner (with the ultimate goal of better reliability & performance).

Background: In our ebook export improvement project for Wikisource, we were able to see an improvement in reliability and performance by adding Symfony. Similarly, we also hope to see such improvements in our OCR project, so we are now doing the same work of adding Symfony.

Acceptance Criteria:

  • Add Symfony to Wikimedia OCR (formerly known as Google OCR)

Related Objects

Event Timeline

ifried created this task.Feb 23 2021, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2021, 7:27 PM
ifried renamed this task from Wikisource OCR: Add Symfony [placeholder] to Wikimedia OCR: Add Symfony [placeholder].Feb 25 2021, 4:07 PM
ifried renamed this task from Wikimedia OCR: Add Symfony [placeholder] to Wikimedia OCR: Add Symfony.
ifried updated the task description. (Show Details)
ARamirez_WMF set the point value for this task to 5.Feb 25 2021, 6:41 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
ifried moved this task from Up Next (June 3-21) to Kanban-2020-21-Q3 on the Community-Tech board.Mar 5 2021, 6:12 PM
ifried edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.
MusikAnimal claimed this task.Mar 5 2021, 6:49 PM
MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.
MusikAnimal added a project: Wikimedia OCR.Mar 5 2021, 8:55 PM
MusikAnimal moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.Mar 16 2021, 8:37 PM
MusikAnimal added a comment.Mar 17 2021, 3:34 PM

Forgot to link to the PR: https://github.com/wikimedia/wikimedia-ocr/pull/1

ifried mentioned this in T277668: Wikisource OCR: Docker container work.Mar 17 2021, 3:42 PM
ifried mentioned this in T277667: Wikisource OCR: add GitHub Actions.
jayantanth subscribed.Mar 28 2021, 7:17 AM
jayantanth unsubscribed.
jayantanth subscribed.
Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Mar 30 2021, 10:18 PM
Samwilson subscribed.

This is done, and on the staging site at https://ocr-test.toolforge.org/

dom_walden moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (Kanban-2020-21-Q3) board.Apr 6 2021, 3:37 PM
dom_walden subscribed.

I have done a bit of testing of the new staging site https://ocr-test.toolforge.org/ (see also T278461#6976391).

I notice that the way we handle uncaught(?) exceptions is a bit different. Previously, we would see the exception message (truncated if it was long). Now, we return a generic The server returned a "500 Internal Server Error". with no extra details. Are we going to setup emailed exceptions like we did with WS Export? @Samwilson @MusikAnimal

For example, compare https://ws-google-ocr.toolforge.org/?image=https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fcommons%2Fthumb%2Fa%2Fa5%2FTest_Book.pdf%2Fpage3-10&lang= with https://ocr-test.toolforge.org/?image=https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fcommons%2Fthumb%2Fa%2Fa5%2FTest_Book.pdf%2Fpage3-10&lang=

MBinder_WMF edited projects, added Community-Tech (CommTech-Sprint-1); removed Community-Tech (Kanban-2020-21-Q3).Apr 6 2021, 8:43 PM
ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-1) board.Apr 6 2021, 9:05 PM
ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-1) board.Apr 7 2021, 3:42 PM
ldelench_wmf closed this task as Resolved.Apr 7 2021, 3:59 PM
MusikAnimal added a comment.Apr 7 2021, 10:23 PM
In T275546#6976585, @dom_walden wrote:

I notice that the way we handle uncaught(?) exceptions is a bit different. Previously, we would see the exception message (truncated if it was long). Now, we return a generic The server returned a "500 Internal Server Error". with no extra details. Are we going to setup emailed exceptions like we did with WS Export? @Samwilson @MusikAnimal

For example, compare https://ws-google-ocr.toolforge.org/?image=https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fcommons%2Fthumb%2Fa%2Fa5%2FTest_Book.pdf%2Fpage3-10&lang= with https://ocr-test.toolforge.org/?image=https%3A%2F%2Fupload.wikimedia.org%2Fwikipedia%2Fcommons%2Fthumb%2Fa%2Fa5%2FTest_Book.pdf%2Fpage3-10&lang=

We'll probably want to adjust how we handle exceptions, similar to what we did for WS Export (capturing common ones). I can make a follow-up PR to capture this error as well as setup the emails.

dmaza subscribed.Apr 7 2021, 11:13 PM
In T275546#6982109, @MusikAnimal wrote:

We'll probably want to adjust how we handle exceptions, similar to what we did for WS Export (capturing common ones). I can make a follow-up PR to capture this error as well as setup the emails.

I've created T279610 and T279609 to keep track of it

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits