Page MenuHomePhabricator

Clean-up hard-coded references to /dev/vda and friends after changing qemu block drivers
Closed, ResolvedPublic

Description

@Bstorm thought it would be a good idea to set the recommended block device driver via image properties in cloud-vps. This means all new buster VMs (and soon stretch VMs) now use the virtio-scsi driver instead of virtio-blk. That's great, but it also changes all device files from /dev/vd* to /dev/sd* on new VMs. The main places that will cause issues is in the new helper script for cinder and the labs_lvm and kubeadm puppet modules.

Event Timeline

It would seem that labs_lvm is actually fine because the vd volume group is baked into the image.

Set the properties on stretch as well since labs_lvm at least will not be broken.

Change 666502 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] labs_lvm: change the default disk in case we ever create an odd image

https://gerrit.wikimedia.org/r/666502

Change 666505 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] kubeadm: remove swap from preflight_checks

https://gerrit.wikimedia.org/r/666505

Change 666505 merged by Bstorm:
[operations/puppet@production] kubeadm: remove swap from preflight_checks

https://gerrit.wikimedia.org/r/666505

Change 666502 merged by Bstorm:
[operations/puppet@production] labs_lvm: change the default disk in case we ever create an odd image

https://gerrit.wikimedia.org/r/666502

Bstorm claimed this task.