Page MenuHomePhabricator

Avoid using User ::isIP, ::getOptions
Closed, ResolvedPublic

Description

User::isIP, User::getOptions were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions and skins:

  • GrowthExperiments(Ext)
  • Echo(Ext)
  • LdapAuthentication(Ext)
  • VisualEditor(Ext)
  • Wikibase(Ext)
  • WikimediaIncubator(Ext)
  • MinervaNeue(Skin)
  • Nostalgia(Skin)
  • GlobalPreferences(Ext)
  • RegexBlock(Ext)
  • BlueSpiceEchoConnector(Ext)
  • BreadCrumbs(Ext)
  • MediaWikiAuth(Ext)
  • LDAPUserInfo(Ext)
  • LookupUser(Ext)
  • BlueSpiceAuthors(Ext)
  • BlueSpiceReaders(Ext)
  • BlueSpiceExtendedSearch(Ext)
  • ChangeAuthor(Ext)
  • CreatedPagesList(Ext)
  • SocialProfile(Ext)
  • Sudo(Ext)
  • StaffPowers(Ext)
  • NoBogusUserpages(Ext)
  • OnlineStatusBar(Ext)
  • BlueSpiceSmartLis(Ext)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/BreadCrumbsmaster+3 -2
mediawiki/extensions/NoBogusUserpagesmaster+4 -1
mediawiki/coremaster+207 -68
mediawiki/extensions/LDAPUserInfomaster+5 -3
mediawiki/extensions/LDAPUserInfoREL1_35+5 -3
mediawiki/extensions/BlueSpiceSmartListmaster+4 -3
mediawiki/extensions/StaffPowersmaster+5 -2
mediawiki/extensions/CreatedPagesListmaster+35 -20
mediawiki/extensions/OnlineStatusBarmaster+28 -3
mediawiki/extensions/ChangeAuthormaster+11 -1
mediawiki/extensions/ChangeAuthormaster+11 -1
mediawiki/extensions/Sudomaster+12 -1
mediawiki/extensions/SocialProfilemaster+6 -3
mediawiki/extensions/BlueSpiceReadersmaster+8 -8
mediawiki/extensions/BlueSpiceAuthorsmaster+4 -2
mediawiki/extensions/LookupUsermaster+22 -2
mediawiki/extensions/BlueSpiceExtendedSearchmaster+5 -2
mediawiki/extensions/GlobalPreferencesmaster+129 -46
mediawiki/extensions/MediaWikiAuthmaster+30 -7
mediawiki/extensions/RegexBlockmaster+4 -2
mediawiki/extensions/BlueSpiceEchoConnectormaster+3 -1
mediawiki/extensions/GrowthExperimentsmaster+17 -10
mediawiki/extensions/WikimediaIncubatormaster+15 -4
mediawiki/extensions/Wikibasemaster+25 -7
mediawiki/skins/MinervaNeuemaster+22 -12
mediawiki/skins/Nostalgiamaster+2 -1
mediawiki/extensions/VisualEditormaster+16 -4
mediawiki/extensions/Echomaster+4 -2
mediawiki/extensions/LdapAuthenticationmaster+2 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 666635 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666635

Change 666622 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666622

Change 666654 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666654

Change 666976 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Wikibase@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666976

Change 666977 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/666977

Change 667137 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/MinervaNeue@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/667137

Change 667164 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/Nostalgia@master] Avoid using User::IsIP

https://gerrit.wikimedia.org/r/667164

Change 667215 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/GlobalPreferences@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/667215

Change 667164 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/667164

Change 667137 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/667137

Change 666976 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/666976

Change 666977 merged by Ebe123:
[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/666977

Change 666605 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/666605

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?
It also will help to move the patch for the core forward.

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?

I'm one of the original authors, but no longer a maintainer (see https://www.mediawiki.org/wiki/Developers/Maintainers)

Hi @Legoktm, @Samwilson.
Since you are the maintainers of the GlobalPreferences extension, could you review the patch, please?

I'm one of the original authors, but no longer a maintainer (see https://www.mediawiki.org/wiki/Developers/Maintainers)

Ok, thanks!

I found out that the GlobalPreferences extension doesn't have any maintainers. But this code base has the code steward - Community Tech.
Could @MusikAnimal, @Samwilson, @HMonroy help with mergeing the patch(Avoid using User ::getOptions, ::getOptionKinds, ::setOption, ::saveSettings) of the GlobalPreferences extension?
This patch blocks the deprecation patch for the core and the patch which will remove the compatibility code from the constructor of the DefaultPreferencesFactory class.

Change 675494 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/RegexBlock@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/675494

Change 675497 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/BlueSpiceEchoConnector@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675497

FYI
I added the undeployed extensions through the CodeSearch to the checklist in the two last updates of the task description .

Change 675522 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/BreadCrumbs@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675522

Change 675570 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):
[mediawiki/extensions/MediaWikiAuth@master] Prevent using User ::addGroup, ::getOptions, ::setOption

https://gerrit.wikimedia.org/r/675570

Change 675497 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceEchoConnector@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675497

Change 675494 merged by Jack Phoenix:
[mediawiki/extensions/RegexBlock@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/675494

Change 675570 merged by jenkins-bot:

[mediawiki/extensions/MediaWikiAuth@master] Remove using User ::addGroup, ::getOptions, ::setOption

https://gerrit.wikimedia.org/r/675570

Change 676583 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LDAPUserInfo@master] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/676583

Change 676597 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LookupUser@master] Avoid using User ::getOptions, ::isIP

https://gerrit.wikimedia.org/r/676597

Change 676610 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceAuthors@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676610

Change 676611 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceReaders@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676611

Change 676612 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/676612

Change 676630 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676630

Change 667215 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Avoid using User ::getOptions, ::getOptionKinds, ::setOption

https://gerrit.wikimedia.org/r/667215

Change 676612 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceExtendedSearch@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/676612

Change 676597 merged by jenkins-bot:

[mediawiki/extensions/LookupUser@master] Avoid using User ::getOptions, ::isIP

https://gerrit.wikimedia.org/r/676597

Change 676720 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/CreatedPagesList@master] Remove usage of deprecated methods in CreatedPagesListRecalculateTest

https://gerrit.wikimedia.org/r/676720

Change 676610 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceAuthors@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676610

Change 676611 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceReaders@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676611

Change 676810 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/SocialProfile@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676810

Change 676812 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Sudo@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676812

Change 676816 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/StaffPowers@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676816

Change 676810 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676810

Change 676812 merged by jenkins-bot:

[mediawiki/extensions/Sudo@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676812

Change 676831 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/NoBogusUserpages@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676831

Change 676630 abandoned by Vlad.shapik:

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

Reason:

Wrong patch

https://gerrit.wikimedia.org/r/676630

Change 676939 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/ChangeAuthor@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676939

Change 676943 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/OnlineStatusBar@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676943

Change 677275 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/BlueSpiceSmartList@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/677275

If all deployed extesions were updated then it's ready for a patch to hard deprecate the methods.

I am working on a patch for the core.

Change 676816 merged by jenkins-bot:

[mediawiki/extensions/StaffPowers@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/676816

Change 677275 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceSmartList@master] Avoid using User::isIP

https://gerrit.wikimedia.org/r/677275

Change 678604 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Hard deprecate User ::isIP, ::getOptions

https://gerrit.wikimedia.org/r/678604

Change 682563 had a related patch set uploaded (by Robert Vogel; author: Vlad.shapik):

[mediawiki/extensions/LDAPUserInfo@REL1_35] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/682563

Change 682563 merged by jenkins-bot:

[mediawiki/extensions/LDAPUserInfo@REL1_35] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/682563

Change 676583 merged by jenkins-bot:

[mediawiki/extensions/LDAPUserInfo@master] Avoid using User ::getOptions, ::GETOPTIONS_EXCLUDE_DEFAULTS

https://gerrit.wikimedia.org/r/676583

Change 678604 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User ::isIP, ::getOptions

https://gerrit.wikimedia.org/r/678604

Change 675522 merged by jenkins-bot:

[mediawiki/extensions/BreadCrumbs@master] Avoid using User::getOptions

https://gerrit.wikimedia.org/r/675522