Page MenuHomePhabricator
Create Task
Maniphest T275609

Add test that repo+client service wiring files are sorted alphabetically
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Use @phpcs-require-sorted-array for service wiring filesmediawiki/extensions/Wikibasemaster+2 -20
Test alphabetical order of service wiring filesmediawiki/extensions/Wikibasemaster+24 -4
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 24 2021, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2021, 11:53 AM
Lucas_Werkmeister_WMDE claimed this task.Feb 24 2021, 11:53 AM
Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Feb 24 2021, 11:55 AM

Change 666397 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Test alphabetical order of service wiring files

https://gerrit.wikimedia.org/r/666397

gerritbot added a project: Patch-For-Review.Feb 24 2021, 11:55 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Feb 24 2021, 11:55 AM
gerritbot added a comment.Feb 25 2021, 10:33 AM

Change 666397 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test alphabetical order of service wiring files

https://gerrit.wikimedia.org/r/666397

Lucas_Werkmeister_WMDE closed this task as Resolved.Feb 25 2021, 10:35 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2021, 11:10 AM
gerritbot added a comment.Feb 25 2021, 11:40 AM

Change 666873 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Use @phpcs-require-sorted-array for service wiring files

https://gerrit.wikimedia.org/r/666873

gerritbot added a project: Patch-For-Review.Feb 25 2021, 11:40 AM
Lucas_Werkmeister_WMDE reopened this task as Open.Feb 25 2021, 12:14 PM
Lucas_Werkmeister_WMDE moved this task from Done to Up for review on the Wikibase Service Migration board.

Reopening this since there’s a possible improvement (using T247813: Create a sniff to enforce alphabetical order of literal arrays).

gerritbot added a comment.Feb 26 2021, 10:15 AM

Change 666873 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use @phpcs-require-sorted-array for service wiring files

https://gerrit.wikimedia.org/r/666873

ItamarWMDE closed this task as Resolved.Feb 26 2021, 10:20 AM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Feb 26 2021, 11:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits