Page MenuHomePhabricator
Create Task
Maniphest T275615

'impact_module_state' is a required property
Closed, ResolvedPublic
Actions

Description

This happens for the HomepageVisit schema on Bengali wikipedia, where we have the Impact module disabled (T270294: Scale: deploy without impact module). We hadn't noticed this issue before because Impact module has always been enabled on all other wikis.

Details

SubjectRepoBranchLines +/-
Impact: Use "notrendered" state for event loggingmediawiki/extensions/GrowthExperimentsmaster+13 -7
EventLoggingSchemas: Bump HomepageVisit versionoperations/mediawiki-configmaster+1 -1
homepagevisit: Add new state for impact moduleschemas/event/secondarymaster+519 -4
Impact module: Add "not rendered" statemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.31+15 -4
Impact module: Add "not rendered" statemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.32+15 -4
Impact module: Add "not rendered" statemediawiki/extensions/GrowthExperimentsmaster+15 -4
testwiki: Bump HomepageVisit EventLogging schema versionoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

kostajh triaged this task as High priority.Feb 24 2021, 1:02 PM
kostajh created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2021, 1:02 PM
kostajh claimed this task.Feb 24 2021, 1:03 PM
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 24 2021, 1:08 PM

Change 666619 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[schemas/event/secondary@master] homepagevisit: Make impact_module_state optional

https://gerrit.wikimedia.org/r/666619

gerritbot added a project: Patch-For-Review.Feb 24 2021, 1:08 PM
kostajh updated the task description. (Show Details)Feb 24 2021, 1:09 PM
gerritbot added a comment.Feb 24 2021, 1:22 PM

Change 666620 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666620

gerritbot added a comment.Feb 24 2021, 1:26 PM

Change 666621 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[operations/mediawiki-config@master] testwiki: Bump HomepageVisit EventLogging schema version

https://gerrit.wikimedia.org/r/666621

MMiller_WMF subscribed.Feb 24 2021, 10:38 PM

@kostajh -- what are the implications of this error? Does it mean we are recording no HomepageVisit events for this wiki? Or is it less severe?

kostajh added a comment.Feb 25 2021, 8:30 AM
In T275615#6858852, @MMiller_WMF wrote:

@kostajh -- what are the implications of this error? Does it mean we are recording no HomepageVisit events for this wiki? Or is it less severe?

Yes, due to validation errors we are not recording HomepageVisit events for this wiki.

kostajh added a comment.Feb 25 2021, 8:35 AM
In T275615#6859776, @kostajh wrote:
In T275615#6858852, @MMiller_WMF wrote:

@kostajh -- what are the implications of this error? Does it mean we are recording no HomepageVisit events for this wiki? Or is it less severe?

Yes, due to validation errors we are not recording HomepageVisit events for this wiki.

@MMiller_WMF there are multiple patches involved in fixing this, is it OK to wait for HomepageVisit events for bnwiki to begin recording on next Thursday when the next train is in group2, or do we want to try to line up several backports today or early next week?

gerritbot added a comment.Feb 25 2021, 8:38 AM

Change 666621 abandoned by Kosta Harlan:
[operations/mediawiki-config@master] testwiki: Bump HomepageVisit EventLogging schema version

Reason:
Not needed due to If4062472a285238d8763e88a046e8b7b65b18ad1

https://gerrit.wikimedia.org/r/666621

gerritbot added a comment.Feb 25 2021, 8:42 AM

Change 666840 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Impact: Use "notrendered" state for event logging

https://gerrit.wikimedia.org/r/666840

gerritbot added a comment.Feb 25 2021, 8:45 AM

Change 666842 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[operations/mediawiki-config@master] EventLoggingSchemas: Bump HomepageVisit version

https://gerrit.wikimedia.org/r/666842

kostajh mentioned this in T269965: Growth EventLogging schemas with validation errors.Feb 25 2021, 10:40 AM
• mewoph moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 25 2021, 4:39 PM
gerritbot added a comment.Feb 25 2021, 4:54 PM

Change 666620 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666620

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 5:00 PM
gerritbot added a comment.Feb 25 2021, 7:14 PM

Change 666704 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666704

gerritbot added a comment.Feb 25 2021, 7:30 PM

Change 666704 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.32] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666704

Stashbot mentioned this in T270294: Scale: deploy without impact module.Feb 25 2021, 7:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-25T19:40:37Z] <tgr@deploy1001> Synchronized php-1.36.0-wmf.32/extensions/GrowthExperiments/: Backport: [[gerrit:666704|Impact module: Add "not rendered" state (T270294, T275615)]] (duration: 01m 26s)

gerritbot added a comment.Feb 25 2021, 7:41 PM

Change 666986 had a related patch set uploaded (by Gergő Tisza; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.31] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666986

gerritbot added a comment.Feb 25 2021, 7:57 PM

Change 666986 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.31] Impact module: Add "not rendered" state

https://gerrit.wikimedia.org/r/666986

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.31; 2021-02-16); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 8:00 PM
Stashbot added a comment.Feb 25 2021, 8:17 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-25T20:17:05Z] <tgr@deploy1001> Synchronized php-1.36.0-wmf.31/extensions/GrowthExperiments/: Backport: [[gerrit:666704|Impact module: Add "not rendered" state (T270294, T275615)]] (duration: 01m 08s)

kostajh moved this task from QA to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 25 2021, 9:49 PM
MMiller_WMF added a comment.Feb 27 2021, 12:02 AM

@kostajh -- it is okay to wait for the train. Issues with HomepageVisit do not substantially impact our reporting, and it's only on one wiki.

gerritbot added a comment.Mar 1 2021, 12:37 PM

Change 666842 abandoned by Kosta Harlan:
[operations/mediawiki-config@master] EventLoggingSchemas: Bump HomepageVisit version

Reason:
According to T259163 we should be removing the schema entries from here since we have them in extension.json now

https://gerrit.wikimedia.org/r/666842

gerritbot added a comment.Mar 1 2021, 3:25 PM

Change 666619 merged by Gergő Tisza:
[schemas/event/secondary@master] homepagevisit: Add new state for impact module

https://gerrit.wikimedia.org/r/666619

gerritbot added a comment.Mar 1 2021, 6:42 PM

Change 666842 restored by Gergő Tisza:
[operations/mediawiki-config@master] EventLoggingSchemas: Bump HomepageVisit version

https://gerrit.wikimedia.org/r/666842

gerritbot added a comment.Mar 1 2021, 7:38 PM

Change 666842 merged by jenkins-bot:
[operations/mediawiki-config@master] EventLoggingSchemas: Bump HomepageVisit version

https://gerrit.wikimedia.org/r/666842

Stashbot added a comment.Mar 1 2021, 7:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-01T19:41:14Z] <tgr@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:666842|EventLoggingSchemas: Bump HomepageVisit version (T275615)]] (duration: 00m 56s)

gerritbot added a comment.Mar 1 2021, 9:07 PM

Change 666840 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: Use "notrendered" state for event logging

https://gerrit.wikimedia.org/r/666840

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.33; 2021-03-02); removed MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Mar 1 2021, 10:00 PM
Stashbot added a comment.Mar 2 2021, 12:33 AM

Mentioned in SAL (#wikimedia-operations) [2021-03-02T00:33:38Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: REDEPLOY: Config: [[gerrit:666842|EventLoggingSchemas: Bump HomepageVisit version (T275615)]] (duration: 00m 56s)

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 4 2021, 11:23 AM
Etonkovidova closed this task as Resolved.Mar 5 2021, 8:27 PM
Etonkovidova subscribed.

Checked in wmf.33 - no impact_module_state errors are present (and no other errors for bnwiki).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits