Update SecurePoll to use the new HookContainer/HookRunner system
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Hook handling was re-conceived from MediaWiki 1.35, as documented here: https://www.mediawiki.org/wiki/Manual:Hooks#Handling_hooks_in_MediaWiki_1.35_and_later

Most hook handlers in SecurePoll still use the old style and should be updated.

The handler for the hook SpecialPage_initList is an example of how to use the new infrastructure.

Details

	Subject	Repo	Branch	Lines +/-
	Use new hook architecture in SecurePoll	mediawiki/extensions/SecurePoll	master	+140 -140

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Umherirrender	T335536 Hard deprecate class Hooks with all deprecated functions (and remove in 1.42)
Open	None	T254670 [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system
Open	None	T263353 Update all Wikimedia production extensions to use the new HookContainer/HookRunner system
Resolved	STran	T275617 Update SecurePoll to use the new HookContainer/HookRunner system

Event Timeline

Tchanders created this task.Feb 24 2021, 1:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2021, 1:47 PM

Tchanders renamed this task from Modernise hooks in SecurePoll to Update SecurePoll to use the new HookContainer/HookRunner system.Feb 24 2021, 1:49 PM

Tchanders added a parent task: T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system.

ARamirez_WMF set the point value for this task to 3.Feb 24 2021, 5:29 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

• Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Feb 24 2021, 6:49 PM

• Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran claimed this task.Feb 24 2021, 9:55 PM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 667294 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Use new hook architecture in SecurePoll

https://gerrit.wikimedia.org/r/667294

gerritbot added a project: Patch-For-Review.Feb 26 2021, 11:01 PM

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 27 2021, 12:58 AM

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Mar 9 2021, 5:06 PM

Change 667294 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use new hook architecture in SecurePoll

https://gerrit.wikimedia.org/r/667294

Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 7:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 9 2021, 8:00 PM

• Niharika closed this task as Resolved.Mar 16 2021, 1:48 PM

taavi mentioned this in T289950: SecurePoll should use the new hook runner system for its own hooks.Aug 29 2021, 5:40 PM

Umherirrender added a project: Platform Team Initiatives (New Hook System).Jun 9 2023, 8:42 PM