Page MenuHomePhabricator
Create Task
Maniphest T275644

Move WikibaseRepo RdfVocabulary to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T275527: Move LocalEntitySource from WikibaseRepo to service container.

Details

SubjectRepoBranchLines +/-
Remove compatibility code from RdfVocabulary constructormediawiki/extensions/Wikibasemaster+5 -93
Remove $localEntitySourceName from RdfVocabulary()mediawiki/extensions/WikibaseQualityConstraintsmaster+0 -2
Remove $localEntitySourceName from RdfVocabulary()mediawiki/extensions/WikibaseMediaInfomaster+0 -1
Remove $localEntitySourceName from RdfVocabulary()mediawiki/extensions/WikibaseLexememaster+0 -1
Don’t pass local entity source name into RdfVocabularymediawiki/extensions/Wikibasemaster+94 -47
Update WikibaseRepo::getRdfVocabulary() callsmediawiki/extensions/WikibaseQualityConstraintsmaster+5 -6
repo: move RdfVocabulary to service containermediawiki/extensions/Wikibasemaster+134 -46
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 24 2021, 3:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2021, 3:56 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Feb 24 2021, 3:57 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Feb 25 2021, 9:43 AM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Feb 25 2021, 11:35 AM
Lucas_Werkmeister_WMDE claimed this task.Feb 25 2021, 5:00 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Feb 26 2021, 12:16 PM

Change 667148 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move RdfVocabulary to service container

https://gerrit.wikimedia.org/r/667148

gerritbot added a project: Patch-For-Review.Feb 26 2021, 12:16 PM

Change 667149 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getRdfVocabulary() calls

https://gerrit.wikimedia.org/r/667149

gerritbot added a comment.Feb 26 2021, 12:28 PM

Change 667152 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Don’t pass local entity source name into RdfVocabulary

https://gerrit.wikimedia.org/r/667152

Lucas_Werkmeister_WMDE added a comment.Feb 26 2021, 12:28 PM

Can be done after T275527: Move LocalEntitySource from WikibaseRepo to service container.

It turns out the RdfVocabulary constructor hasn’t actually used the local entity source name since Ifa0fe54220, anyways. I uploaded an optional follow-up change to remove it.

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Feb 26 2021, 12:28 PM
gerritbot added a comment.Mar 1 2021, 3:57 PM

Change 667148 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move RdfVocabulary to service container

https://gerrit.wikimedia.org/r/667148

gerritbot added a comment.Mar 1 2021, 3:57 PM

Change 667149 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Update WikibaseRepo::getRdfVocabulary() calls

https://gerrit.wikimedia.org/r/667149

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 4:00 PM
gerritbot added a comment.Mar 1 2021, 5:43 PM

Change 667671 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667671

gerritbot added a comment.Mar 1 2021, 5:43 PM

Change 667672 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667672

gerritbot added a comment.Mar 1 2021, 5:43 PM

Change 667673 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667673

gerritbot added a comment.Mar 1 2021, 5:43 PM

Change 667674 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove compatibility code from RdfVocabulary constructor

https://gerrit.wikimedia.org/r/667674

gerritbot added a comment.Mar 2 2021, 2:16 PM

Change 667152 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t pass local entity source name into RdfVocabulary

https://gerrit.wikimedia.org/r/667152

gerritbot added a comment.Mar 2 2021, 2:16 PM

Change 667671 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667671

gerritbot added a comment.Mar 2 2021, 2:16 PM

Change 667672 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667672

gerritbot added a comment.Mar 2 2021, 3:27 PM

Change 667673 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove $localEntitySourceName from RdfVocabulary()

https://gerrit.wikimedia.org/r/667673

gerritbot added a comment.Mar 2 2021, 4:43 PM

Change 667674 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove compatibility code from RdfVocabulary constructor

https://gerrit.wikimedia.org/r/667674

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 2 2021, 4:53 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL