Page MenuHomePhabricator

Kibana: Render kibana settings file based off of Kibana/Elasticsearch version
Closed, ResolvedPublic

Description

See https://phabricator.wikimedia.org/T262211#6817159 for an example of where we can't have the settings newsfeed.enabled nor telemetry.enabled if we're running (for example) Elasticsearch 6.5.4 instead of Elasticsearch 7.x

We're noticing this problem as a result of bringing the new relforge100[3,4] into service. As such, the solution should not change the behavior for any non-relforge current usage of profile::kibana. In order to do this, let's introduce a new variable profile::kibana::config_version: 6 (note: could also use profile::elasticsearch::config_version but it's probably bad form to have profile::kibana depend on a profile::elasticsearch variable) that we can set in hieradata/role/common/elasticsearch/relforge.yaml .

AC

  • Relforge can now rely on profile::kibana provided that relforge's hieradata has set profile::kibana::config_version: 6. Additionally the behavior for anything that doesn't set profile::kibana::config_version should stay the same

Event Timeline

Change 666677 had a related patch set uploaded (by Ryan Kemper; owner: Ryan Kemper):
[operations/puppet@production] kibana: use different settings based off version

https://gerrit.wikimedia.org/r/666677

Mentioned in SAL (#wikimedia-operations) [2021-02-26T05:25:14Z] <ryankemper> [relforge] Downtimed relforge1004 until 2021-03-02 07:23:36 (https://phabricator.wikimedia.org/T275658 is in flight to fix broken kibana.service)

Change 666677 merged by Gehel:
[operations/puppet@production] kibana: use different settings based off version

https://gerrit.wikimedia.org/r/666677

Mentioned in SAL (#wikimedia-operations) [2021-03-01T18:26:23Z] <ryankemper> [Relforge] Lifting downtime on relforge1004 now that T275658 is done