See https://phabricator.wikimedia.org/T262211#6817159 for an example of where we can't have the settings newsfeed.enabled nor telemetry.enabled if we're running (for example) Elasticsearch 6.5.4 instead of Elasticsearch 7.x
We're noticing this problem as a result of bringing the new relforge100[3,4] into service. As such, the solution should not change the behavior for any non-relforge current usage of profile::kibana. In order to do this, let's introduce a new variable profile::kibana::config_version: 6 (note: could also use profile::elasticsearch::config_version but it's probably bad form to have profile::kibana depend on a profile::elasticsearch variable) that we can set in hieradata/role/common/elasticsearch/relforge.yaml .
- Relforge can now rely on profile::kibana provided that relforge's hieradata has set profile::kibana::config_version: 6. Additionally the behavior for anything that doesn't set profile::kibana::config_version should stay the same