Page MenuHomePhabricator
Create Task
Maniphest T27575

JavaScriptMinifier should preserve IE's "Conditional compilation" statements
Closed, DeclinedPublic
Actions

Description

Author: mdale

Description:
the syntax /*@cc_on*/ is sometimes used to conditionally add content to IE browsers see:
http://www.javascriptkit.com/javatutors/conditionalcompile.shtml

Its useful in cases where client detection library is not ready yet or you need to do user-agent independent IE conditionals.

Minification in resource loader should probably ignore striping comments that include /*@cc_on at the start. and @/ at the end.

Version: 1.17.x
Severity: enhancement

Details

Reference
bz25575

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 11:22 PM
• bzimport added a project: MediaWiki-ResourceLoader.
• bzimport set Reference to bz25575.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Oct 19 2010, 12:00 AM
• TrevorParscal added a comment.Oct 21 2010, 6:37 AM

Yes, this is brilliant! More JSMin tweaks to make I guess...

• bzimport added a comment.Aug 19 2011, 7:12 PM

mhershberger wrote:

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Krinkle added a comment.Mar 6 2013, 5:32 AM

See also:
http://msdn.microsoft.com/en-us/library/ie/121hztk3(v=vs.94).aspx

Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.Apr 28 2015, 6:35 PM
Krinkle closed this task as Declined.Jun 14 2017, 9:47 PM

Use of /*@cc_on @*/ is mainly for old IE. As of writing, we no longer support Grade A JavaScript run-time in IE6, IE7, IE8 or IE9. Support for /*@cc_on @*/ was removed in IE 11. IE 10 still support it for back-compat, but I don't think it makes sense to introduce support for this deprecated feature at this point in time.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL