Page MenuHomePhabricator

Remove the trash icons which show next to the parameter name when it's "in focus"
Closed, ResolvedPublic2 Estimated Story Points

Description

Don't show trash icons in the content pane.

Related Objects

StatusSubtypeAssignedTask
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedLena_WMDE
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedECohen_WMDE
ResolvedAndrew-WMDE
ResolvedNone
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedNone
Resolvedawight
ResolvedAndrew-WMDE
InvalidNone
Resolvedthiemowmde
Resolvedawight
ResolvedECohen_WMDE
InvalidNone

Event Timeline

Lena_WMDE set the point value for this task to 2.Apr 14 2021, 1:11 PM

@ECohen_WMDE @Lena_WMDE Are we also planning to remove the trash button next to each template in a multi-part transclusion? I made that assumption in T272355#7087933 but now I'm not sure whether I've seen this requirement anywhere.

Illustration:

image.png (726×806 px, 70 KB)

@ECohen_WMDE @Lena_WMDE Are we also planning to remove the trash button next to each template in a multi-part transclusion? I made that assumption in T272355#7087933 but now I'm not sure whether I've seen this requirement anywhere.

Yup these should be removed at the same time as the other trashcans. Templates can still be removed in multi-part transclusions using the toolbar at the bottom of the sidebar. Should that be added to this ticket or a new one?

Yup these should be removed at the same time as the other trashcans. Templates can still be removed in multi-part transclusions using the toolbar at the bottom of the sidebar. Should that be added to this ticket or a new one?

Thanks, I see this is being done as part of T274263 so no need to add!

Change 704754 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Remove trash icons from the content view

https://gerrit.wikimedia.org/r/704754

Change 704754 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove trash icons from the content view

https://gerrit.wikimedia.org/r/704754

It was worst decision to remove them. I used it a lot and it was much more convenient than what we have now. The time taken to delete unused parameters has increased by 2 times. Instead of quick clicks on empty fields - you now have to look at the list of which ones you want to remove. There is no indication in the list whether the paramter is filled or not.