Hi all!

Please see https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment for the list of things to do to get a new extension deployed to WMF production.

In T275774#7082921, @greg wrote:

Hi all!

Please see https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment for the list of things to do to get a new extension deployed to WMF production.

I took this to mean that we haven't done all the steps we should have done before requesting a performance review, so having read through, here are the things in this list that we don't have, as far as I can tell:

• puppet role for mediawiki-vagrant - that seems quite straightforward, but optional. If this needs done, I'll absolutely get on it
• a user guide - is this a thing we should actually have since this sends a one-time notification, with no other user interaction?
• a separate project on phabricator - This seems like it would result in a mostly inactive component project because of the nature of the extension - could we just reuse our existing phab group and one of its components?

Is there an easier way to test this on Beta than making 100 edits manually?

The link to the code in the task description is broken for me: https://gerrit.wikimedia.org/r/mediawiki/extensions/TheWikipediaLibrary (Not found)

In terms of what to measure, I presume that the notification is a standard Echo one? How/when is it created?

Is there an easier way to test this on Beta than making 100 edits manually?

Not to my knowledge. We could lower the edit threshold, though that would mean a lot more folks would get the notification. I'm very open to suggestions on how best to make this less of a chore.

The link to the code in the task description is broken for me: https://gerrit.wikimedia.org/r/mediawiki/extensions/TheWikipediaLibrary (Not found)

Updated task description

In terms of what to measure, I presume that the notification is a standard Echo one?

Yes, it creates a notification with the following attributes:

'canNotifyAgent' => true,
'category' => 'system',
'group' => 'positive',
'section' => 'message',

How/when is it created?
We fire the message in the PageSaveComplete hook if the editor is eligible.

In T275774#7085340, @jsn.sherman wrote:

I took this to mean that we haven't done all the steps we should have done before requesting a performance review.

Mostly just generally and I can't find a tracking task that has all of these as blockers so it was hard for me to verify quickly :)

Also, another call out is the listing of the extension on the Dev/Maintainers page for stewardship of the extension in production.

Mostly just generally and I can't find a tracking task that has all of these as blockers so it was hard for me to verify quickly :)

T132084 is our tracking task, I'll go make sure we have all those blockers (like security review, etc) to it. Sorry for making life difficult!

Also, another call out is the listing of the extension on the Dev/Maintainers page for stewardship of the extension in production.

👍 Thanks!

I've looked at the code where the notification is created. Since you're correctly doing this in a DeferredUpdate, there shouldn't be any measurable impact on Save Timing. I don't think this extension required new metrics to be measured.

The icon (twl-eligible.svg) can be optimised. Running it through ImageOptim I see at least 15% possible savings on file weight.

@Gilles thanks for that feedback! I don't have access to ImageOptim specifically, but I was able to trim that image down by about 15% as you suggested and opened up a change request for it (T283527).

@greg I think we've got the tracking task (T132084) and dev/maintainers page populated with all the relevant info we have now.

Okay, we're just waiting on a +2 on that change request.
We have a few other blocking tasks that are not in the extension itself that we want to take care of before deploying and sending the notifications, but we've done all the stuff that we know needs done on the extension. @Gilles, is there anything else we need to do to move through the performance review gate?

T283527 has been merged.

Whoo-hoo! Thanks!