Page MenuHomePhabricator

WS Export download button doesn’t work on multilingual Wikisource
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to Reproduce

  1. Open a page on multilingual Wikisource, e.g. Бзыикъо заом иорэд.
  2. Click the blue Download button in the upper right corner.
  3. Hover over the download links (or examine their link target by whatever means you like).

Actual Results

  1. The links point to https://ws-export.wmcloud.org/?page=…&lang=en&format=…
  2. When you click on them, WS Export’s main interface appears complaining about missing page.

Expected Results

  1. The links point to https://ws-export.wmcloud.org/?page=…&lang=www&format=…
  2. When you click them, the work is exported in the requested format.

(Note that this is a bug of the extension, not the WS Export tool itself, but the extension doesn’t seem to have an own Phabricator tag. Feel free to change tags as needed.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson set the point value for this task to 3.

I think the thing to do here is to check if $wgServerName contains wikisource.org and if it does use the subdomain as the lang parameter, unless there's no subdomain in which case lang should be mul. If the server name isn't Wikisource, it should keep using the content language code (useful in development only). And while we're there, we might as well handle Beta Wikisource too?

Change 670341 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] Use subdomain to get language code for Wikisources

https://gerrit.wikimedia.org/r/670341

Change 670341 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Use subdomain to get language code for Wikisources

https://gerrit.wikimedia.org/r/670341

dom_walden added a subscriber: dom_walden.

The bug in the description is no longer reproducible.

The WS Export links on Multilingual Wikisource are now correct. This includes the "Download" button and the sidebar links.

This is now on production.

Test Environment: https://wikisource.org Wikisource – (686e258) 18:09, 15 March 2021.

ifried added a subscriber: ifried.

I have tested downloading PDF, EPUB, and MOBI for the link provided above in the description (for both the download button & sidebar links). The bug is no longer reproducible. I'm marking this work as Done.