WS Export download button doesn’t work on multilingual Wikisource
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Feb 25 2021, 10:39 PM

Description

Steps to Reproduce

Open a page on multilingual Wikisource, e.g. Бзыикъо заом иорэд.
Click the blue Download button in the upper right corner.
Hover over the download links (or examine their link target by whatever means you like).

Actual Results

The links point to https://ws-export.wmcloud.org/?page=…&lang=en&format=…
When you click on them, WS Export’s main interface appears complaining about missing page.

Expected Results

The links point to https://ws-export.wmcloud.org/?page=…&lang=www&format=…
When you click them, the work is exported in the requested format.

(Note that this is a bug of the extension, not the WS Export tool itself, but the extension doesn’t seem to have an own Phabricator tag. Feel free to change tags as needed.)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use subdomain to get language code for Wikisources	mediawiki/extensions/Wikisource	master	+77 -13

Customize query in gerrit

Related Objects

Mentioned Here: rEWSO686e258728bd: Merge "Use subdomain to get language code for Wikisources"

Event Timeline

Tacsipacsi created this task.Feb 25 2021, 10:39 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 25 2021, 10:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Feb 26 2021, 11:08 PM

Samwilson claimed this task.Mar 10 2021, 5:55 AM

Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.

Samwilson set the point value for this task to 3.

Samwilson added a project: All-and-every-Wikisource.

I think the thing to do here is to check if $wgServerName contains wikisource.org and if it does use the subdomain as the lang parameter, unless there's no subdomain in which case lang should be mul. If the server name isn't Wikisource, it should keep using the content language code (useful in development only). And while we're there, we might as well handle Beta Wikisource too?

Change 670341 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] Use subdomain to get language code for Wikisources

https://gerrit.wikimedia.org/r/670341

gerritbot added a project: Patch-For-Review.Mar 10 2021, 6:13 AM

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q3) board.Mar 10 2021, 6:21 AM

Change 670341 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] Use subdomain to get language code for Wikisources

https://gerrit.wikimedia.org/r/670341

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2021, 6:11 PM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Mar 15 2021, 6:13 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 15 2021, 7:00 PM

The bug in the description is no longer reproducible.

The WS Export links on Multilingual Wikisource are now correct. This includes the "Download" button and the sidebar links.

This is now on production.

Test Environment: https://wikisource.org Wikisource – (686e258) 18:09, 15 March 2021.

I have tested downloading PDF, EPUB, and MOBI for the link provided above in the description (for both the download button & sidebar links). The bug is no longer reproducible. I'm marking this work as Done.

Thanks for fixing it!

WS Export download button doesn’t work on multilingual WikisourceClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions