Page MenuHomePhabricator

Theme preview is janky and saving can appear to UNAPPLY them until a hard refresh is performed
Closed, ResolvedPublic

Description

Preview can at times seem to... flicker? Mostly it only really stands out when actually saving them and the whole theme goes away, though.

Like we need to make sure applying and saving the theme does so in a way that tells mw/the browser to refresh the css?

Event Timeline

Further jankiness:

  • Already applied theme disappears when going to appearance tab and needs to be hard-refreshed to get back. Possibly this is the real issue here?
  • I was wrong about themes not applying to newvector; that also just needed a hard refresh...

Change 667379 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/Theme@master] Theme live preview JS fixes

https://gerrit.wikimedia.org/r/667379

Change 667379 merged by jenkins-bot:
[mediawiki/extensions/Theme@master] Theme live preview JS fixes

https://gerrit.wikimedia.org/r/667379

ashley claimed this task.