Page MenuHomePhabricator

Clicking the mention toolbar button multiple times inserts multiple '@'s into the document
Closed, ResolvedPublic

Description

If the cursor is to the right of the trigger character, it should probably not re-insert it.

Cool! One (likely) bug: if I press the reply button multiple times, it adds multiple @s.

Event Timeline

@Esanders: are you able to add more details to the talk description? In its current state, it's not clear to me what is/is not happening.

Esanders renamed this task from Pressing mention multiple times inserts multiple '@' to Clicking the mention toolbar button multiple times inserts multiple '@'s into the document.Mar 15 2021, 5:23 PM

Change 673522 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Don't insert multiple '@' when clicking the mention toolbar button multiple times

https://gerrit.wikimedia.org/r/673522

Change 673522 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Don't insert multiple '@' when clicking the mention toolbar button multiple times

https://gerrit.wikimedia.org/r/673522