| Esanders | |
| Feb 26 2021, 11:21 PM |
| F35023625: image.png | |
| Mar 25 2022, 1:50 PM |
| F35023623: image.png | |
| Mar 25 2022, 1:50 PM |
| F34124349: image.png | |
| Feb 26 2021, 11:21 PM |
| F34124353: image.png | |
| Feb 26 2021, 11:21 PM |
Echo renders OOUI icons at 30x30, which is 1.5 scale. This is usually fine as the icons are SVGs, but it email it deliberately uses rasterized versions (presumably for better email client support), which results in blurriness.
The icons should be scaled to 30x30 before rasterizing.
Current:
Expected:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Set all icons used in EchoNotificationIcons to 30x30 | Esanders | mediawiki/extensions/Echo | master | +17 -17 |
Change 773773 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/Echo@master] Set all icons used in EchoNotificationIcons to 30x30
It would be nicer if ResourceLoaderImageModule could rasterize to an arbitrary size, but this is an easier fix for now.
Before patch:
After patch:
Tested by enabling the "Inbox" extension (which can be done on Patch demo)
Where are the rasterised images stored? How are they changed? Will this Just Work™ and trigger new renders, will they start working after the caches expire in a year, or will they randomly re-render at some indeterminate point when Varnish evicts them?
They're fetched from ResourceLoaderImageModule (via load.php) so I imagine the longest they will be cached for is a week?
Change 773773 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Set all icons used in EchoNotificationIcons to 30x30