Page MenuHomePhabricator

Introduce a setting for enabling the text editing toolbar in DiscussionTools' source mode
Closed, ResolvedPublic

Description

T257391#6865400 makes it possible for the text editing toolbar to be offered within the Reply and New Discussion Tools' source modes.

This task is about introducing/exposing a setting that enables people to turn the text editing toolbar within Reply and New Discussion Tools' source modes on/off.

Deployment timing

Not yet defined. @ppelberg to add the deployment date once it's been set.

Requirements

  • When the setting is "enabled," people should see the same text editing tools/toolbar available within Reply and New Discussion Tools' source modes, available in its visual modes.
  • When the setting is "disabled," people should NOT see any text editing tools/toolbar within Reply and New Discussion Tools' source modes.
  • By default, the setting for enabling/disabling text editing tools/toolbar available within the Reply and New Discussion Tools' source modes should be TURNED OFF.
  • People should NOT be able to turn the experimental toolbar setting on if they have both the Enable quick topic adding and Enable quick replying settings TURNED OFF.
  • The setting should read as follows: Enable experimental tools in the quick replying and quick topic adding features' Source modes.

Open questions

  • 1. Where should people go to turn the text editing toolbar within DiscussionTools's source mode on/off?
    • For now, the setting will be available in Special:Preferences#mw-prefsection-editing's Discussion page section
  • 2. How should this setting be configured by default?
    • For now, this setting will be TURNED OFF by default.

Done

  • Requirements are implemented
  • All Open questions are answered

Event Timeline

Change 667368 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Make the source mode toolbar a user preference feature

https://gerrit.wikimedia.org/r/667368

@Esanders Will it be enabled or disabled as default?

@Esanders Will it be enabled or disabled as default?

Good question, @Patriccck. To start, the text editing tools will not be available by default within the Reply and New Discussion Tools' source modes.

Note: we have not yet decided precisely how and when this will be deployed.

Note: we have not yet decided precisely how and when this will be deployed.

The rollout plan can be found here: T257391#6887213.

The above patch shows the preference along side the others:

@Esanders: are you able to adjust the setting's language to read: Enable tools for pinging, linking and text formatting when quick replying or quick topic adding.

ppelberg updated the task description. (Show Details)

META
Updated the task description's Requirements section with:

  • Revised copy to describe the setting
  • A new requirement that the experimental tools in source mode setting not be operational if people have both quick topic adding and quick replying settings turned off.

Change 667368 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Make the source mode toolbar a user preference feature

https://gerrit.wikimedia.org/r/667368

Everything is implemented, we just need to change the configuration to make the new preference available. I'm not sure when I should do that.

Test wiki created on Patch Demo by PPelberg (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/796beebbda/w/

Change 676426 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Make sourcemodetoolbar preference available

https://gerrit.wikimedia.org/r/676426

Test wiki created on Patch Demo by Matma Rex using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/8f2e5b2384/w/

ppelberg added a project: Skipped QA.