Page MenuHomePhabricator

The Toolhub message ", \" probably doesn't need translation
Closed, ResolvedPublic

Description

This Toolhub message appears on translatewiki: https://translatewiki.net/wiki/Wikimedia:Toolhub-42060f-,_%5C/en

It just says , \. Its documentation links to https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/toolhub/+/refs/heads/main/toolhub/apps/search/schema.py#55

I'm not sure what it is, but it looks like it shouldn't be translatable.

Event Timeline

@Amire80 I wasn't sure, so I made it a translatable string, but maybe you can help me either change that decision or fix up the translation notes. The string is used in python code that looks like ", ".join([list, of, things, to, join]). This results in an output string like list, of, things, to, join. I was unsure if the comma character is a universal list separation character or if it should be translated in some locales.

It looks like the comment lines are out of sync with the source files yet again (gnu gettext is nice, but not as nice as our banana format). The actual code where it is used is:

return [
    build_parameter_type(
        name=self.target.search_param,
        required=False,
        location="query",
        description=_("Search in %(fields)s")
        % {
            "fields": _(", ").join(search_fields),
        },
        schema={"type": "string"},
    )
]

The search_fields that is joined there will contain English language labels for the backend database fields that are searched. We really can't localize these labels easily, so in this case at least the output string from the join will be a delimiter separated list of English words like 'title' and 'name'.

bd808 triaged this task as Low priority.Sep 3 2021, 9:29 PM

Thanks for updating the documentation.

Is it possible to also get rid of the backslash in the source message? It's probably similar to T283906.