Page MenuHomePhabricator

Article::getTouched was deprecated in MediaWiki 1.35
Closed, ResolvedPublic

Description

Use of Article::getTouched was deprecated in MediaWiki 1.35. [Called from WidgetRenderer::wiki_get_timestamp in /home/username/site.com/extensions/Widgets/WidgetRenderer.php at line 176]

MediaWiki 1.35.0
PHP 7.4.12 (cgi-fcgi)
MySQL 5.7.28-log
ICU 57.1
Lua 5.1.5

Backtrace:
GlobalFunctions.php line 1029 calls MWDebug::deprecated()
Article.php line 2737 calls wfDeprecated()
WidgetRenderer.php line 176 calls Article->getTouched()
smarty_internal_resource_registered.php line 63 calls WidgetRenderer::wiki_get_timestamp()
smarty_internal_resource_registered.php line 33 calls Smarty_Internal_Resource_Registered->getTemplateTimestamp()
smarty_template_source.php line 182 calls Smarty_Internal_Resource_Registered->populate()
smarty_internal_template.php line 168 calls Smarty_Template_Source::load()
Smarty.class.php line 1028 calls Smarty_Internal_Template->__construct()
smarty_internal_templatebase.php line 189 calls Smarty->createTemplate()
smarty_internal_templatebase.php line 116 calls Smarty_Internal_TemplateBase->_execute()
WidgetRenderer.php line 112 calls Smarty_Internal_TemplateBase->fetch()
Parser.php line 3340 calls WidgetRenderer::renderWidget()
Parser.php line 3047 calls Parser->callParserFunction()
PPFrame_Hash.php line 253 calls Parser->braceSubstitution()
Parser.php line 2887 calls PPFrame_Hash->expand()
Parser.php line 1556 calls Parser->replaceVariables()
Parser.php line 651 calls Parser->internalParse()
OutputPage.php line 2113 calls Parser->parse()
OutputPage.php line 2063 calls OutputPage->parseInternal()
Skin.php line 1923 calls OutputPage->parseAsInterface()
WANObjectCache.php line 1529 calls Skin->{closure}()
WANObjectCache.php line 1376 calls WANObjectCache->fetchOrRegenerate()
Skin.php line 1924 calls WANObjectCache->getWithSetCallback()
Skin.php line 1949 calls Skin->getCachedNotice()
SkinTemplate.php line 421 calls Skin->getSiteNotice()
SkinTemplate.php line 127 calls SkinTemplate->prepareQuickTemplate()
SkinTemplate.php line 144 calls SkinTemplate->generateHTML()
OutputPage.php line 2615 calls SkinTemplate->outputPage()
MediaWiki.php line 947 calls OutputPage->output()
MediaWiki.php line 960 calls MediaWiki->{closure}()
MediaWiki.php line 543 calls MediaWiki->main()
index.php line 53 calls MediaWiki->run()
index.php line 46 calls wfIndexMain()

Event Timeline

Zabe added a project: User-Zabe.
Zabe moved this task from Backlog to Deprecation on the User-Zabe board.
Zabe subscribed.

Change 669974 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/extensions/Widgets@master] Use Article::getPage()->getTouched(), not Article::getTouched

https://gerrit.wikimedia.org/r/669974

Change 669974 merged by jenkins-bot:
[mediawiki/extensions/Widgets@master] Use Article::getPage()->getTouched(), not Article::getTouched()

https://gerrit.wikimedia.org/r/669974

I am not sure about the release cycles, but it should be fixed in the next version.

@Zabe Thanks a lot for your effort! Since the deprecation started with MW 1.35 it will be good to back-port the change to the REL1_35 branch. That will be cool. With the new Gerrit web interface I myself have no longer a clue how to do this. :(

That’s a good idea. I am gonna take a look at that this evening.

Change 670195 had a related patch set uploaded (by Zabe; owner: Zabe):
[mediawiki/extensions/Widgets@REL1_35] Use Article::getPage()->getTouched(), not Article::getTouched()

https://gerrit.wikimedia.org/r/670195

Umherirrender updated the task description. (Show Details)

Change 670195 merged by jenkins-bot:
[mediawiki/extensions/Widgets@REL1_35] Use Article::getPage()->getTouched(), not Article::getTouched()

https://gerrit.wikimedia.org/r/670195