Page MenuHomePhabricator
Create Task
Maniphest T276035

Avoid using User ::getDefaultOptions, ::getDefaultOption
Closed, ResolvedPublic
Actions

Description

User::getDefaultOptions, User::getDefaultOption were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions:

  • MultimediaViewer
  • LiquidThreads
  • PdfHandler
  • Scribunto
  • WikimediaEvents
  • CentralAuth
  • TEI

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove the compatibility code from the constructor of the DefaultPreferencesFactorymediawiki/coremaster+8 -29
Deprecate construction of DefaultPreferencesFactory without $userOptionsLookupmediawiki/coremaster+4 -1
Avoid using User ::getDefaultOption, ::getDefaultOptionsmediawiki/coremaster+89 -21
Avoid using User ::getDefaultOption, ::getOptionmediawiki/extensions/CentralAuthmaster+4 -4
Avoid using User::getDefaultOptionmediawiki/extensions/LiquidThreadsmaster+5 -3
Avoid using User::getDefaultOptionmediawiki/extensions/TEImaster+7 -1
Avoid using User::getDefaultOptionmediawiki/extensions/PdfHandlermaster+7 -1
Avoid using User::getDefaultOptionmediawiki/extensions/Scribuntomaster+2 -2
Avoid using User::getDefaultOptionmediawiki/extensions/WikimediaEventsmaster+3 -1
Avoid using User::getDefaultOptionsmediawiki/extensions/MultimediaViewermaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Vlad.shapik created this task.Mar 1 2021, 9:15 AM
gerritbot added a comment.Mar 1 2021, 9:42 AM

Change 667543 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getDefaultOptions

https://gerrit.wikimedia.org/r/667543

gerritbot added a project: Patch-For-Review.Mar 1 2021, 9:42 AM
gerritbot added a comment.Mar 1 2021, 10:25 AM

Change 667552 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/PdfHandler@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667552

gerritbot added a comment.Mar 1 2021, 10:44 AM

Change 667555 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Scribunto@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667555

gerritbot added a comment.Mar 1 2021, 12:00 PM

Change 667577 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/WikimediaEvents@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667577

Vlad.shapik added a comment.EditedMar 1 2021, 1:08 PM

Since the LiquidThreads extension is unmaintained, I didn't replace hard deprected User::getDefaultOption method. However this extension is deployed.

gerritbot added a comment.Mar 1 2021, 7:32 PM

Change 667577 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667577

gerritbot added a comment.Mar 1 2021, 7:37 PM

Change 667555 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667555

gerritbot added a comment.Mar 1 2021, 7:37 PM

Change 667543 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getDefaultOptions

https://gerrit.wikimedia.org/r/667543

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 8:00 PM
• CCicalese_WMF triaged this task as Medium priority.Mar 2 2021, 6:38 PM
• CCicalese_WMF moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.
• CCicalese_WMF moved this task from UserStore pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Mar 2 2021, 6:41 PM
Aklapper added a comment.Mar 2 2021, 7:51 PM

For the records, LiquidThreads is deployed on Wikimedia servers (1, 2), so before hard deprecation it would have also need to receive a code change somehow...

gerritbot added a comment.Mar 5 2021, 3:55 PM

Change 667552 merged by jenkins-bot:
[mediawiki/extensions/PdfHandler@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667552

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 5 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 5 2021, 4:10 PM
Vlad.shapik mentioned this in rEPHDc73192e23dca: Avoid using User::getDefaultOption.Mar 5 2021, 5:31 PM
• Pchelolo added a comment.Mar 5 2021, 6:28 PM

LiquidThreads still needs updating. After that a patch needs to be made for hard-deprecation.

• Pchelolo moved this task from Waiting for Review to Doing on the Platform Team Workboards (MW Expedition) board.Mar 5 2021, 6:29 PM
Vlad.shapik added a comment.Mar 5 2021, 6:30 PM

Ok, I will do it.

gerritbot added a comment.Mar 8 2021, 11:17 AM

Change 669774 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/LiquidThreads@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/669774

gerritbot added a project: Patch-For-Review.Mar 8 2021, 11:17 AM
Vlad.shapik updated the task description. (Show Details)Mar 8 2021, 11:22 AM
gerritbot added a comment.Mar 9 2021, 8:36 PM

Change 670282 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/CentralAuth@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670282

Vlad.shapik updated the task description. (Show Details)Mar 9 2021, 8:36 PM
Vlad.shapik added a project: MediaWiki-extensions-CentralAuth.Mar 9 2021, 8:42 PM
gerritbot added a comment.Mar 9 2021, 8:57 PM

Change 670285 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/TEI@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670285

Vlad.shapik updated the task description. (Show Details)Mar 9 2021, 9:10 PM
gerritbot added a comment.Mar 10 2021, 10:26 AM

Change 670431 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Avoid using User ::getDefaultOption, ::getDefaultOptions

https://gerrit.wikimedia.org/r/670431

gerritbot added a comment.Mar 12 2021, 2:42 AM

Change 670285 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670285

Vlad.shapik mentioned this in rETEId22a86e78c6f: Avoid using User::getDefaultOption.Mar 12 2021, 2:44 AM
gerritbot added a comment.Mar 13 2021, 3:15 PM

Change 671600 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

https://gerrit.wikimedia.org/r/671600

gerritbot added a comment.Mar 15 2021, 4:51 PM

Change 669774 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/669774

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 15 2021, 5:00 PM
gerritbot added a comment.Mar 15 2021, 7:40 PM

Change 670282 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using User ::getDefaultOption, ::getOption

https://gerrit.wikimedia.org/r/670282

gerritbot added a comment.Mar 16 2021, 4:44 PM

Change 670431 merged by jenkins-bot:
[mediawiki/core@master] Avoid using User ::getDefaultOption, ::getDefaultOptions

https://gerrit.wikimedia.org/r/670431

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 16 2021, 5:00 PM
gerritbot added a comment.Mar 22 2021, 11:42 AM

Change 673993 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

https://gerrit.wikimedia.org/r/673993

gerritbot added a comment.Mar 22 2021, 11:42 AM

Change 671600 abandoned by Vlad.shapik:
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

Reason:

https://gerrit.wikimedia.org/r/671600

gerritbot added a comment.Mar 23 2021, 8:43 AM

Change 674260 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Edit the compatibility code for UserOptionsLookup

https://gerrit.wikimedia.org/r/674260

gerritbot added a comment.Mar 23 2021, 8:44 AM

Change 673993 abandoned by Vlad.shapik:
[mediawiki/core@master] Remove the compatibility code for UserOptionsLookup

Reason:

https://gerrit.wikimedia.org/r/673993

gerritbot added a comment.Mar 23 2021, 9:34 AM

Change 673993 restored by Vlad.shapik:
[mediawiki/core@master] Remove the compatibility code for UserOptionsLookup

https://gerrit.wikimedia.org/r/673993

Kizule added a subtask: T278257: PreferencesList extension: Pass the UserOptionsLookup service to the DefaultPreferencesFactory in PreferencesListUtils class.Mar 23 2021, 8:16 PM
Kizule closed subtask T278257: PreferencesList extension: Pass the UserOptionsLookup service to the DefaultPreferencesFactory in PreferencesListUtils class as Resolved.Mar 25 2021, 5:19 PM
Vlad.shapik moved this task from Doing to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Apr 5 2021, 10:19 AM
• Pchelolo closed this task as Resolved.Apr 13 2021, 12:50 PM
• Pchelolo moved this task from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
gerritbot added a comment.Apr 13 2021, 1:11 PM

Change 673993 merged by jenkins-bot:

[mediawiki/core@master] Remove the compatibility code from the constructor of the DefaultPreferencesFactory

https://gerrit.wikimedia.org/r/673993

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 13 2021, 2:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits