Page MenuHomePhabricator

Avoid using User ::getDefaultOptions, ::getDefaultOption
Closed, ResolvedPublic

Description

User::getDefaultOptions, User::getDefaultOption were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions:

  • MultimediaViewer
  • LiquidThreads
  • PdfHandler
  • Scribunto
  • WikimediaEvents
  • CentralAuth
  • TEI

Event Timeline

Change 667543 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getDefaultOptions

https://gerrit.wikimedia.org/r/667543

Change 667552 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/PdfHandler@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667552

Change 667555 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Scribunto@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667555

Change 667577 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/WikimediaEvents@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667577

Since the LiquidThreads extension is unmaintained, I didn't replace hard deprected User::getDefaultOption method. However this extension is deployed.

Change 667577 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667577

Change 667555 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667555

Change 667543 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Avoid using User::getDefaultOptions

https://gerrit.wikimedia.org/r/667543

For the records, LiquidThreads is deployed on Wikimedia servers (1, 2), so before hard deprecation it would have also need to receive a code change somehow...

Change 667552 merged by jenkins-bot:
[mediawiki/extensions/PdfHandler@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/667552

LiquidThreads still needs updating. After that a patch needs to be made for hard-deprecation.

Change 669774 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/LiquidThreads@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/669774

Change 670282 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/CentralAuth@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670282

Change 670285 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/TEI@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670285

Change 670431 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] Avoid using User ::getDefaultOption, ::getDefaultOptions

https://gerrit.wikimedia.org/r/670431

Change 670285 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/670285

Change 671600 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

https://gerrit.wikimedia.org/r/671600

Change 669774 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Avoid using User::getDefaultOption

https://gerrit.wikimedia.org/r/669774

Change 670282 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Avoid using User ::getDefaultOption, ::getOption

https://gerrit.wikimedia.org/r/670282

Change 670431 merged by jenkins-bot:
[mediawiki/core@master] Avoid using User ::getDefaultOption, ::getDefaultOptions

https://gerrit.wikimedia.org/r/670431

Change 673993 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

https://gerrit.wikimedia.org/r/673993

Change 671600 abandoned by Vlad.shapik:
[mediawiki/core@master] Deprecate construction of DefaultPreferencesFactory without $userOptionsLookup

Reason:

https://gerrit.wikimedia.org/r/671600

Change 674260 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/core@master] Edit the compatibility code for UserOptionsLookup

https://gerrit.wikimedia.org/r/674260

Change 673993 abandoned by Vlad.shapik:
[mediawiki/core@master] Remove the compatibility code for UserOptionsLookup

Reason:

https://gerrit.wikimedia.org/r/673993

Change 673993 restored by Vlad.shapik:
[mediawiki/core@master] Remove the compatibility code for UserOptionsLookup

https://gerrit.wikimedia.org/r/673993

Change 673993 merged by jenkins-bot:

[mediawiki/core@master] Remove the compatibility code from the constructor of the DefaultPreferencesFactory

https://gerrit.wikimedia.org/r/673993