Actual error:

dcaro@clouddb1003:~$ sudo run-puppet-agent
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Osm::Planet_sync[gis]: expects a value for parameter 'engine' (file: /etc/puppet/modules/profile/manifests/wmcs/services/postgres/osm_primary.pp, line: 32) on node clouddb1003.clouddb-services.eqiad.wmflabs
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Might be related to https://phabricator.wikimedia.org/T269582, looking...

Yes, the change that introduced the error is https://gerrit.wikimedia.org/r/c/operations/puppet/+/644482

Adding a new parameter engine.

@MSantos hi, the change https://gerrit.wikimedia.org/r/c/operations/puppet/+/644482, added a new engine required parameter that our manifests (profile/manifests/wmcs/services/postgres/osm_primary.pp) are not passing and no default or updates on our manifests were made.

Can you guide me on what and where should I change to adapt to it? (should I hardcode the engine name on our module? Add a default? Is there anything else needed?).

Thanks!

I didn't realise this module was used outside of the maps profile, apologies. You can add engine => "osm2pgsql" as a parameter to osm::planet_sync to restore the previous behaviour.

Ack thanks! I'll try to add a dummy test so it explodes before and we catch it in review :)

Change 667560 had a related patch set uploaded (by David Caro; owner: David Caro):
[operations/puppet@production] wmcs.postrgesql.osm_primary: add missing required engine param

https://gerrit.wikimedia.org/r/667560

Change 667560 merged by David Caro:
[operations/puppet@production] wmcs.postrgesql.osm_primary: add missing required engine param

https://gerrit.wikimedia.org/r/667560