Page MenuHomePhabricator
Create Task
Maniphest T276080

Port VotePage to have service dependencies
Closed, ResolvedPublic
Actions

Description

Following T275648: Allow services to be injected into SecurePoll ActionPages, inject service dependencies via the VotePage constructor.

See T276076: Port CreatePage to have service dependencies for an example of how to do this.

Details

SubjectRepoBranchLines +/-
Port VotePage to have service dependenciesmediawiki/extensions/SecurePollmaster+28 -4
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Mar 1 2021, 12:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2021, 12:01 PM
Tchanders renamed this task from Port EntryPage to have service dependencies to Port VotePage to have service dependencies.Mar 1 2021, 12:01 PM
Tchanders updated the task description. (Show Details)
• TThoabala claimed this task.Mar 2 2021, 3:15 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Mar 2 2021, 3:54 PM

Change 667882 had a related patch set uploaded (by TsepoThoabala; owner: TsepoThoabala):
[mediawiki/extensions/SecurePoll@master] Port VotePage to have service dependencies

https://gerrit.wikimedia.org/r/667882

gerritbot added a project: Patch-For-Review.Mar 2 2021, 3:54 PM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Mar 2 2021, 3:55 PM
gerritbot added a comment.Mar 2 2021, 9:04 PM

Change 667882 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Port VotePage to have service dependencies

https://gerrit.wikimedia.org/r/667882

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2021, 9:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 2 2021, 10:00 PM
Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Mar 3 2021, 3:33 PM
• Niharika closed this task as Resolved.Mar 4 2021, 4:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL