Page MenuHomePhabricator

Improve service mocking in service wiring unit tests
Closed, ResolvedPublic

Description

Currently, when testing the service wiring, we mock dependent services by mocking the get() method in each test, either using $this->once() and willReturn() if it’s only one service, or a willReturnCallback() with a switch ( $id ) if there are multiple services. This gets relatively unwieldy, and we’d like to find a more convenient solution.

Event Timeline

Change 667229 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: simplify service mocking in service wiring tests

https://gerrit.wikimedia.org/r/667229

Change 667229 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: simplify service mocking in service wiring tests

https://gerrit.wikimedia.org/r/667229

Change 667839 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] client: simplify service mocking in service wiring tests

https://gerrit.wikimedia.org/r/667839

Change 667841 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Miscellaneous ServiceWiringTestCase improvements

https://gerrit.wikimedia.org/r/667841

Change 667839 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] client: simplify service mocking in service wiring tests

https://gerrit.wikimedia.org/r/667839

Change 667841 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Miscellaneous ServiceWiringTestCase improvements

https://gerrit.wikimedia.org/r/667841