Page MenuHomePhabricator
Create Task
Maniphest T276090

Assert in service wiring unit tests that no DB/HTTP calls are made
Closed, ResolvedPublic
Actions

Description

The old WikibaseRepoTest and WikibaseClientTest classes override some MediaWiki services to ensure that the service setup never makes database or HTTP accesses (T243729). We should have something similar in the new unit tests for service wiring.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+14 -11repo: also mock getDBLoadBalancer() in service wiring tests
mediawiki/extensions/Wikibasemaster+47 -0client: disallow DB+HTTP access in service wiring
mediawiki/extensions/Wikibasemaster+44 -0repo: disallow DB+HTTP access in service wiring
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 1 2021, 1:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2021, 1:28 PM
gerritbot added a comment.Mar 1 2021, 1:29 PM

Change 667230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667230

gerritbot added a project: Patch-For-Review.Mar 1 2021, 1:29 PM
Lucas_Werkmeister_WMDE claimed this task.Mar 1 2021, 1:29 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Up for review on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Mar 1 2021, 6:19 PM

Change 667230 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667230

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 7:10 PM
Rosalie_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.Mar 2 2021, 8:55 AM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 2 2021, 9:54 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Done to Ready to pick up on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE claimed this task.Mar 2 2021, 10:48 AM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Mar 2 2021, 10:50 AM

Change 667840 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] client: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667840

gerritbot added a project: Patch-For-Review.Mar 2 2021, 10:50 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 2 2021, 10:50 AM
gerritbot added a comment.Mar 2 2021, 4:56 PM

Change 667890 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: also mock getDBLoadBalancer() in service wiring tests

https://gerrit.wikimedia.org/r/667890

gerritbot added a comment.Mar 3 2021, 2:42 PM

Change 667840 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] client: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667840

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 3 2021, 2:43 PM
gerritbot added a comment.Mar 3 2021, 2:46 PM

Change 667890 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: also mock getDBLoadBalancer() in service wiring tests

https://gerrit.wikimedia.org/r/667890

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 3 2021, 2:56 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 3 2021, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL