Page MenuHomePhabricator

Assert in service wiring unit tests that no DB/HTTP calls are made
Closed, ResolvedPublic

Description

The old WikibaseRepoTest and WikibaseClientTest classes override some MediaWiki services to ensure that the service setup never makes database or HTTP accesses (T243729). We should have something similar in the new unit tests for service wiring.

Event Timeline

Change 667230 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667230

Change 667230 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667230

Change 667840 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] client: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667840

Change 667890 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: also mock getDBLoadBalancer() in service wiring tests

https://gerrit.wikimedia.org/r/667890

Change 667840 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] client: disallow DB+HTTP access in service wiring

https://gerrit.wikimedia.org/r/667840

Change 667890 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: also mock getDBLoadBalancer() in service wiring tests

https://gerrit.wikimedia.org/r/667890