Page MenuHomePhabricator
Create Task
Maniphest T276094

Avoid using User ::addGroup, ::removeGroup, ::getAllGroups, ::clearNotification
Closed, DuplicatePublic
Actions

Assigned To
Vlad.shapik
Authored By
Vlad.shapik
Mar 1 2021, 1:45 PM
Tags
Referenced Files
None
Subscribers
Aklapper
• Pchelolo
Vlad.shapik

Description

User::addGroup, User::removeGroup, User::getAllGroups, User::clearNotification were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions:

  • Echo
  • LdapAuthentication
  • Wikibase
  • CentralAuth
  • AbuseFilter
  • Translate
  • Flow
  • UserMerge
  • MassMessage
  • GlobalCssJs
  • BetaFeatures

Details

SubjectRepoBranchLines +/-
Avoid using User::addGroup() methodmediawiki/extensions/BetaFeaturesmaster+2 -4
Avoid using User::addGroupmediawiki/extensions/MassMessagemaster+1 -1
Avoid using User::addGroup and User::removeGroupmediawiki/extensions/Translatemaster+20 -4
Avoid using User ::addGroup, ::removeGroup, ::getAllGroupsmediawiki/extensions/LdapAuthenticationmaster+4 -3
Stop using deprecated User::addGroup in testsmediawiki/extensions/AbuseFiltermaster+1 -1
Avoid using User::addGroupmediawiki/extensions/Echomaster+4 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Vlad.shapik created this task.Mar 1 2021, 1:45 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 1 2021, 1:45 PM
gerritbot added a comment.Mar 1 2021, 2:27 PM

Change 667602 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Stop using deprecated User::addGroup in tests

https://gerrit.wikimedia.org/r/667602

gerritbot added a project: Patch-For-Review.Mar 1 2021, 2:27 PM
taavi updated the task description. (Show Details)Mar 1 2021, 2:28 PM
gerritbot added a comment.Mar 1 2021, 3:02 PM

Change 667615 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/Echo@master] Avoid using User::addGroup

https://gerrit.wikimedia.org/r/667615

gerritbot added a comment.Mar 1 2021, 4:16 PM

Change 667632 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::addGroup, ::removeGroup, ::getAllGroups

https://gerrit.wikimedia.org/r/667632

Daimona updated the task description. (Show Details)Mar 1 2021, 5:16 PM
gerritbot added a comment.Mar 1 2021, 6:35 PM

Change 667615 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Avoid using User::addGroup

https://gerrit.wikimedia.org/r/667615

Vlad.shapik updated the task description. (Show Details)Mar 1 2021, 6:39 PM
Vlad.shapik updated the task description. (Show Details)
gerritbot added a comment.Mar 1 2021, 6:41 PM

Change 667602 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Stop using deprecated User::addGroup in tests

https://gerrit.wikimedia.org/r/667602

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 7:00 PM
• Pchelolo closed this task as a duplicate of T275148: Prepare User group methods for hard deprecation.Mar 1 2021, 7:58 PM

There's already a subtask for group-related methods: T275148

gerritbot added a comment.Mar 2 2021, 7:43 PM

Change 667632 merged by jenkins-bot:
[mediawiki/extensions/LdapAuthentication@master] Avoid using User ::addGroup, ::removeGroup, ::getAllGroups

https://gerrit.wikimedia.org/r/667632

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 2 2021, 8:00 PM
gerritbot added a comment.Mar 6 2021, 7:07 PM

Change 669132 had a related patch set uploaded (by Artrix; owner: Artrix):
[mediawiki/extensions/MassMessage@master] Avoid using User::addGroup

https://gerrit.wikimedia.org/r/669132

gerritbot added a comment.Mar 6 2021, 8:19 PM

Change 669153 had a related patch set uploaded (by Artrix; owner: Artrix):
[mediawiki/extensions/Translate@master] Avoid using User::addGroup and User::removeGroup

https://gerrit.wikimedia.org/r/669153

gerritbot added a comment.Mar 11 2021, 7:59 PM

Change 670929 had a related patch set uploaded (by Artrix; owner: Artrix):
[mediawiki/extensions/BetaFeatures@master] Avoid using User::addGroup() method

https://gerrit.wikimedia.org/r/670929

gerritbot added a comment.Mar 17 2021, 5:28 AM

Change 669153 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid using User::addGroup and User::removeGroup

https://gerrit.wikimedia.org/r/669153

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 17 2021, 6:00 AM
ArTrix updated the task description. (Show Details)Mar 17 2021, 10:57 AM
ArTrix updated the task description. (Show Details)
gerritbot added a comment.Mar 22 2021, 8:30 PM

Change 669132 abandoned by Ppchelko:
[mediawiki/extensions/MassMessage@master] Avoid using User::addGroup

Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/ /673719

https://gerrit.wikimedia.org/r/669132

Peter.ovchyn moved this task from Unsorted pile to On the train on the Platform Team Workboards (MW Expedition) board.Apr 5 2021, 10:12 AM
gerritbot added a comment.Jun 6 2021, 11:50 AM

Change 670929 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Avoid using User::addGroup() method

https://gerrit.wikimedia.org/r/670929

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 6 2021, 12:00 PM
ArTrix updated the task description. (Show Details)Jun 8 2021, 1:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits