Fix smaller design issues related to ReferencePreviews settings icon
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	thiemowmde
	Mar 2 2021, 9:23 AM

Description

Smaller design issues we run into after T234205:

While in Beta, the cog wheel is hidden, but the space is reserved. Can we remove this unnecessary whitespace as long as we are in Beta?
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/668473
The height of the popup is not exactly the one we wanted (from T246029) after the cog wheel was added. Patch-For-Review:
- https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/664783

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix bottom margin as long as settings icon isn't shown	mediawiki/extensions/Popups	master	+15 -9
	remove spacing, when the footer is empty	mediawiki/extensions/Popups	master	+10 -2

Customize query in gerrit

Related Objects

Mentioned In: T346404: When reference previews is a beta feature the settings cog does not display for logged in users
T277639: Settings pop up for RefPreviews and Page Previews
Mentioned Here: T234205: Add cog wheel to the popup to disable ReferencePreviews
T246029: Increase max-height of reference previews

Event Timeline

thiemowmde created this task.Mar 2 2021, 9:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2021, 9:23 AM

Lena_WMDE moved this task from Backlog to Before Default on the Reference Previews board.Mar 2 2021, 1:42 PM

Lena_WMDE set the point value for this task to 3.Mar 3 2021, 9:19 AM

Lena_WMDE edited projects, added WMDE-TechWish-Sprint-2021-03-03; removed WMDE-TechWish.

lilients_WMDE claimed this task.Mar 3 2021, 10:30 AM

lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-03 board.

Lena_WMDE moved this task from Before Default to Doing on the Reference Previews board.Mar 4 2021, 2:08 PM

Change 668473 had a related patch set uploaded (by Svantje Lilienthal; owner: Svantje Lilienthal):
[mediawiki/extensions/Popups@master] remove spacing, when the footer is empty

https://gerrit.wikimedia.org/r/668473

gerritbot added a project: Patch-For-Review.Mar 4 2021, 4:02 PM

Change 668473 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] remove spacing, when the footer is empty

https://gerrit.wikimedia.org/r/668473

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 4 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 5:10 PM

Lena_WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-03-03 board.Mar 4 2021, 5:38 PM

lilients_WMDE updated the task description. (Show Details)Mar 5 2021, 8:39 AM

lilients_WMDE moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-03-03 board.Mar 5 2021, 12:45 PM

Hey - just checked on beta and noticed that the spacing is looking better, but a bit off still. Can we make the bottom margin equal to the current top margin? At the moment it's noticeably smaller. Since this could remain in beta for awhile on some wikis, many editors will still see it in this form without the cog wheel.

Screen Shot 2021-03-11 at 16.47.27.png (172×373 px, 33 KB)

Change 670908 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix bottom margin as long as settings icon isn't shown

https://gerrit.wikimedia.org/r/670908

gerritbot added a project: Patch-For-Review.Mar 11 2021, 6:33 PM

@ECohen_WMDE I uploaded a patch. As it turns out:

This is only an issue when the popup opens to the top, not when it opens to the bottom. This might be why we haven't noticed.
It's an old issue, dating back before ReferencePreviews.

Lena_WMDE mentioned this in T277639: Settings pop up for RefPreviews and Page Previews.Mar 17 2021, 10:09 AM

Change 670908 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix bottom margin as long as settings icon isn't shown

https://gerrit.wikimedia.org/r/670908

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 11:11 AM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 21 2021, 12:00 PM

Lena_WMDE closed this task as Resolved.May 17 2021, 9:14 AM

thiemowmde mentioned this in T346404: When reference previews is a beta feature the settings cog does not display for logged in users.Sep 15 2023, 6:56 AM

	F34151982: Screen Shot 2021-03-11 at 16.47.27.png
	Mar 11 2021, 3:52 PM

Fix smaller design issues related to ReferencePreviews settings iconClosed, ResolvedPublic3 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Fix smaller design issues related to ReferencePreviews settings icon
Closed, ResolvedPublic3 Estimated Story Points
Actions