Page MenuHomePhabricator

Fix smaller design issues related to ReferencePreviews settings icon
Closed, ResolvedPublic3 Estimated Story Points

Description

Smaller design issues we run into after T234205:

Event Timeline

Lena_WMDE set the point value for this task to 3.Mar 3 2021, 9:19 AM

Change 668473 had a related patch set uploaded (by Svantje Lilienthal; owner: Svantje Lilienthal):
[mediawiki/extensions/Popups@master] remove spacing, when the footer is empty

https://gerrit.wikimedia.org/r/668473

Change 668473 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] remove spacing, when the footer is empty

https://gerrit.wikimedia.org/r/668473

Hey - just checked on beta and noticed that the spacing is looking better, but a bit off still. Can we make the bottom margin equal to the current top margin? At the moment it's noticeably smaller. Since this could remain in beta for awhile on some wikis, many editors will still see it in this form without the cog wheel.

Screen Shot 2021-03-11 at 16.47.27.png (172×373 px, 33 KB)

Change 670908 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix bottom margin as long as settings icon isn't shown

https://gerrit.wikimedia.org/r/670908

@ECohen_WMDE I uploaded a patch. As it turns out:

  • This is only an issue when the popup opens to the top, not when it opens to the bottom. This might be why we haven't noticed.
  • It's an old issue, dating back before ReferencePreviews.

Change 670908 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix bottom margin as long as settings icon isn't shown

https://gerrit.wikimedia.org/r/670908