Page MenuHomePhabricator

Remove the unused code
Open, Needs TriagePublic

Description

My console after starting the server gives the following result. Remove the unwanted code, test the tool and create a patch :-)

WARNING in src\components\Sidebar.jsx
  Line 1:8:     'React' is defined but never used        no-unused-vars
  Line 41:7:    Must use destructuring props assignment  react/destructuring-assignment
  Line 150:16:  `{' '}` must be placed on a new line     react/jsx-one-expression-per-line

src\components\home.jsx
  Line 1:8:     'React' is defined but never used              no-unused-vars
  Line 74:21:   Identifier 'backend_url' is not in camel case  camelcase
  Line 89:33:   `{' '}` must be placed on a new line           react/jsx-one-expression-per-line
  Line 97:8:    `{' '}` must be placed on a new line           react/jsx-one-expression-per-line
  Line 104:11:  `{' '}` must be placed on a new line           react/jsx-one-expression-per-line

Event Timeline

Change 668254 had a related patch set uploaded (by Sandyabhi; owner: Sandyabhi):
[labs/tools/VideoCutTool@master] Removed the unused code

https://gerrit.wikimedia.org/r/668254

Change 668254 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Removed the unused code

https://gerrit.wikimedia.org/r/668254

Hey ! I would like to solve this issue please assign it to me and yes please tell me from where to get the code base to get started as early as possible and remove all the unused codes😄

Gopavasanth added a subscriber: Sandyabhi.

@Gaurav24072002 Thanks for your interest! I think @Sandyabhi made most of the work on this task! If you still find any unused code please feel free to make a patch!

Check: https://phabricator.wikimedia.org/project/profile/4054/ for the code repositories :)

Change 673501 had a related patch set uploaded (by Sandyabhi; owner: Sandyabhi):
[labs/tools/VideoCutTool@master] Remove unused code from home.js

https://gerrit.wikimedia.org/r/673501

Change 673501 abandoned by Sandyabhi:
[labs/tools/VideoCutTool@master] Remove unused code from home.js

Reason:

https://gerrit.wikimedia.org/r/673501

Hey , @Gopavasanth I have found few unused function parameters in home.js. Should I create a patch ?

Gopavasanth updated the task description. (Show Details)

@Sandyabhi , Please feel free to re-assign yourself if you want to fix :)

Soda subscribed.

@Punith.nyk Feel free to assign yourself tasks if you want to work on them :)

@Soda Should I also eliminate the eslint errors

image.png (773×1 px, 145 KB)
?

Hey, @Soda I found some lint errors & I have fixed it. Should I create a patch?