Page MenuHomePhabricator
Create Task
Maniphest T276312

Move WikibaseRepo TermsCollisionDetectorFactory to service container
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
repo: move TermsCollisionDetectorFactory to service containermediawiki/extensions/Wikibasemaster+57 -43
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 3 2021, 11:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2021, 11:38 AM
Lucas_Werkmeister_WMDE claimed this task.Mar 3 2021, 11:42 AM
Lucas_Werkmeister_WMDE mentioned this in T276245: Move WikibaseRepo EntityChangeOpProvider to service container.
Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T276313: Move WikibaseRepo PropertyTermsCollisionDetector to service container.Mar 3 2021, 11:46 AM
Lucas_Werkmeister_WMDE mentioned this in T276314: Move WikibaseRepo ItemTermsCollisionDetector to service container.
gerritbot added a comment.Mar 3 2021, 11:58 AM

Change 668045 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move TermsCollisionDetectorFactory to service container

https://gerrit.wikimedia.org/r/668045

gerritbot added a project: Patch-For-Review.Mar 3 2021, 11:58 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 3 2021, 11:58 AM
Lucas_Werkmeister_WMDE added a comment.Mar 3 2021, 1:36 PM

Damn, this fails with the same errors as T276245.

Lucas_Werkmeister_WMDE moved this task from Up for review to Doing on the Wikibase Service Migration board.Mar 3 2021, 1:36 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 3 2021, 2:20 PM
Lucas_Werkmeister_WMDE mentioned this in T276358: Move WikibaseRepo TypeIdsStore to service container.Mar 3 2021, 5:14 PM
gerritbot added a comment.Mar 4 2021, 8:28 AM

Change 668045 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move TermsCollisionDetectorFactory to service container

https://gerrit.wikimedia.org/r/668045

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 4 2021, 9:00 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 4 2021, 9:09 AM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 9:10 AM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 5 2021, 12:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL