Page MenuHomePhabricator
Create Task
Maniphest T276320

Unbreak elastic search tests
Closed, ResolvedPublic
Actions

Description

Sometime this week elastic search tests started failing, seems like something to do with upgrading ruflin.

https://github.com/wmde/wikibase-release-pipeline/pull/78/checks?check_run_id=2020942809

[0-0] executing: docker exec  test_wikibase_1 php extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php --startOver
[0-0] Error: Command failed: docker exec  test_wikibase_1 php extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php --startOver
[3e8bfb9228c410ca976223cf] [no req]   Error from line 451 of /var/www/html/vendor/ruflin/elastica/lib/Elastica/Index.php: Class 'Elasticsearch\Endpoints\Indices\Aliases\Update' not found
Backtrace:
#0 /var/www/html/extensions/CirrusSearch/includes/Maintenance/Validators/SpecificAliasValidator.php(137): Elastica\Index->addAlias(string, boolean)
#1 /var/www/html/extensions/CirrusSearch/includes/Maintenance/Validators/SpecificAliasValidator.php(79): CirrusSearch\Maintenance\Validators\SpecificAliasValidator->updateFreeIndices(array)
#2 /var/www/html/extensions/CirrusSearch/includes/Maintenance/Validators/IndexAliasValidator.php(98): CirrusSearch\Maintenance\Validators\SpecificAliasValidator->updateIndices(array, array)
#3 /var/www/html/extensions/CirrusSearch/maintenance/UpdateOneSearchIndexConfig.php(458): CirrusSearch\Maintenance\Validators\IndexAliasValidator->validate()
#4 /var/www/html/extensions/CirrusSearch/maintenance/UpdateOneSearchIndexConfig.php(411): CirrusSearch\Maintenance\UpdateOneSearchIndexConfig->validateSpecificAlias()
#5 /var/www/html/extensions/CirrusSearch/maintenance/UpdateOneSearchIndexConfig.php(269): CirrusSearch\Maintenance\UpdateOneSearchIndexConfig->validateAlias()
#6 /var/www/html/extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php(61): CirrusSearch\Maintenance\UpdateOneSearchIndexConfig->execute()
#7 /var/www/html/maintenance/doMaintenance.php(107): CirrusSearch\Maintenance\UpdateSearchIndexConfig->execute()
#8 /var/www/html/extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php(70): require_once(string)
#9 {main}

    at ChildProcess.exithandler (child_process.js:308:12)
    at ChildProcess.emit (events.js:314:20)
    at ChildProcess.EventEmitter.emit (domain.js:483:12)
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5) {
  killed: false,
  code: 255,
  signal: null,
  cmd: 'docker exec  test_wikibase_1 php extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php --startOver'
}
[0-0] Assertion failed
Assertion failed

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Add test for SpecificAliasValidatorTobias Anderssonmediawiki/extensions/CirrusSearchREL1_35+41 -0
Add test for SpecificAliasValidatorTobias Anderssonmediawiki/extensions/CirrusSearchmaster+41 -0
Explicitly set elasticsearch/elasticsearch dependencyReedymediawiki/extensions/Elasticamaster+1 -0
Explicitly set elasticsearch/elasticsearch dependencyTobias Anderssonmediawiki/extensions/ElasticaREL1_35+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• toan created this task.Mar 3 2021, 12:27 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMar 3 2021, 12:27 PM
• toan claimed this task.Mar 3 2021, 12:27 PM
• toan moved this task from To do to Doing on the Wikibase Release Strategy (Sprint 2.1) board.
• toan moved this task from Doing to Done on the Wikibase Release Strategy (Sprint 2.1) board.Mar 4 2021, 1:52 PM

https://github.com/wmde/wikibase-release-pipeline/pull/85 solved it

• toan moved this task from Done to Doing on the Wikibase Release Strategy (Sprint 2.1) board.Mar 5 2021, 3:42 PM
• toan updated the task description. (Show Details)EditedMar 5 2021, 4:31 PM

Seems like that did not solve the original problem.

composer installing on REL1_35 of cirrussearch gives us the wrong elasticsearch/elasticsearch version.

Seems to only happen using php 7.3

image.png (1,904×711 px, 920 KB)

gerritbot added a comment.Mar 5 2021, 4:40 PM

Change 668693 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/CirrusSearch@REL1_35] Set dependency

https://gerrit.wikimedia.org/r/668693

gerritbot added a project: Patch-For-Review.Mar 5 2021, 4:40 PM
• toan moved this task from Doing to Peer Review on the Wikibase Release Strategy (Sprint 2.1) board.Mar 5 2021, 4:44 PM
gerritbot added a comment.Mar 7 2021, 2:45 PM

Change 668691 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Elastica@REL1_35] Set elasticsearch/elasticsearch dependency

https://gerrit.wikimedia.org/r/668691

Reedy subscribed.EditedMar 7 2021, 6:24 PM

I would also suggest reporting this Upstream at https://github.com/ruflin/Elastica/issues

Because their constraints and apparently aren't compatible with what their upstream have done...

Reedy added a project: Upstream.Mar 7 2021, 6:31 PM

Filed https://github.com/ruflin/Elastica/issues/1908

Reedy mentioned this in T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.Mar 8 2021, 7:21 PM
Reedy added a subtask: T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.Mar 8 2021, 7:26 PM
gerritbot added a comment.Mar 8 2021, 9:38 PM

Change 669796 had a related patch set uploaded (by Reedy; owner: Tobias Andersson):
[mediawiki/extensions/Elastica@master] Explicitly set elasticsearch/elasticsearch dependency

https://gerrit.wikimedia.org/r/669796

JeroenDeDauw awarded a token.Mar 8 2021, 9:47 PM
gerritbot added a comment.Mar 8 2021, 9:54 PM

Change 668691 merged by jenkins-bot:
[mediawiki/extensions/Elastica@REL1_35] Explicitly set elasticsearch/elasticsearch dependency

https://gerrit.wikimedia.org/r/668691

gerritbot added a comment.Mar 8 2021, 9:56 PM

Change 668379 had a related patch set uploaded (by Reedy; owner: Tobias Andersson):
[mediawiki/extensions/CirrusSearch@master] Add test for SpecificAliasValidator

https://gerrit.wikimedia.org/r/668379

gerritbot added a comment.Mar 8 2021, 10:19 PM

Change 669796 merged by jenkins-bot:
[mediawiki/extensions/Elastica@master] Explicitly set elasticsearch/elasticsearch dependency

https://gerrit.wikimedia.org/r/669796

gerritbot added a comment.Mar 9 2021, 12:34 AM

Change 668379 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add test for SpecificAliasValidator

https://gerrit.wikimedia.org/r/668379

gerritbot added a comment.Mar 9 2021, 12:59 AM

Change 668693 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@REL1_35] Add test for SpecificAliasValidator

https://gerrit.wikimedia.org/r/668693

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 1:00 AM
• toan added a comment.Mar 9 2021, 8:22 AM
In T276320#6890414, @Reedy wrote:

Filed https://github.com/ruflin/Elastica/issues/1908

Thank you 🙏

• toan added a comment.Mar 9 2021, 9:13 AM

Seems to be building and passing tests again https://github.com/wmde/wikibase-release-pipeline/actions/runs/635145562

• toan moved this task from Peer Review to Done on the Wikibase Release Strategy (Sprint 2.1) board.Mar 9 2021, 9:14 AM
WMDE-leszek closed this task as Resolved.Apr 27 2021, 7:48 PM
Reedy closed subtask T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed as Resolved.Dec 16 2022, 6:07 PM
Maintenance_bot added a project: Wikidata.Dec 16 2022, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits