Page MenuHomePhabricator

Avoid using User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk
Closed, ResolvedPublic

Description

User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk were soft deprecated and now need to be hard deprecated. So we need to remove using from:

  • (Skin) Nostalgia
  • (Skin) Tempo
  • (Skin) BlueSky

Event Timeline

Change 668086 had a related patch set uploaded (by Vlad.shapik; owner: Vlad.shapik):
[mediawiki/skins/Nostalgia@master] Avoid using User::getNewTalk

https://gerrit.wikimedia.org/r/668086

Change 668086 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Avoid using User::getNewTalk

https://gerrit.wikimedia.org/r/668086

Change 668523 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/skins/BlueSky@master] Remove BC hacks

https://gerrit.wikimedia.org/r/668523

Change 668524 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/skins/Tempo@master] Remove BC hacks and set MW version

https://gerrit.wikimedia.org/r/668524

Change 668523 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Remove BC hacks

https://gerrit.wikimedia.org/r/668523

daniel triaged this task as Medium priority.Mar 9 2021, 6:26 PM

Ready for hard for a patch adding hard deprecations.

Change 668524 merged by jenkins-bot:
[mediawiki/skins/Tempo@master] Remove BC hacks and set MW version

https://gerrit.wikimedia.org/r/668524

Change 678586 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] UserTests: create test cases to check triggering of the deprecation warning in the User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk

https://gerrit.wikimedia.org/r/678586

Change 678586 abandoned by Vlad.shapik:

[mediawiki/core@master] UserTest: create test cases to check triggering of the deprecation warning in the User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk

Reason:

There is no need to add these tests.

https://gerrit.wikimedia.org/r/678586

There aren't any usages of User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk in the core. These methods are hard deprecated, so the ticket could be marked as a resolved.