Page MenuHomePhabricator

Review proof-of-concept VE template dialog sidebar code
Closed, ResolvedPublic5 Estimated Story Points

Description

  • What works about our data handling in the POC?
  • What do we think about the search indexing?
  • What was awkward?
  • Summarize findings.

POC diff against base revision: https://gitlab.com/wmde/mediawiki-extensions-VisualEditor/-/compare/bc0347259ba4837913bee9e734bafb519e6efbfa...wmde-alpha-deploy?from_project_id=21116650&view=inline&w=1

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedWMDE-Fisch
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedAndrew-WMDE
ResolvedBUG REPORTawight
OpenNone
OpenNone
ResolvedNone
InvalidNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedNone
ResolvedNone
Resolvedthiemowmde
ResolvedAndrew-WMDE
ResolvedWMDE-Fisch
ResolvedLena_WMDE
ResolvedNone
ResolvedECohen_WMDE
OpenNone

Event Timeline

awight set the point value for this task to 5.
awight renamed this task from Review proof-of-concept VE template dialog sidebar to Review proof-of-concept VE template dialog sidebar code.May 17 2021, 8:05 AM

What could be improved:

  • ve.ui.MWTemplateDialog.prototype.onReplacePart explicitly removes "search" field elements rather than relying on encapsulation: (a). Each template, including its search fields, should be encapsulated: (b)
  • Failure to hide knowledge when looking up part IDs: (a) (b)
  • Moving a transclusion part is increasingly awkward. (a)