Page MenuHomePhabricator
Create Task
Maniphest T276341

geoshapes: improve DB handling during tests
Closed, DeclinedPublic
Actions

Description

Background information

geoshapes access a PostgreSQL DB to function properly. The current architecture does not provide an interface for testing.

What

Handle DB interactions properly and make code better suited for tests.

How

TBD

Open questions

...

Acceptance criteria

  • Documentation is updated
  • Remove skipping logic for DB handlers
  • Add some tests for the DB interactions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
add mock property to DB configurationmediawiki/services/geoshapesmaster+23 -19
Customize query in gerrit

Related Objects

Event Timeline

MSantos created this task.Mar 3 2021, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2021, 3:25 PM
gerritbot added a comment.Mar 3 2021, 8:00 PM

Change 668185 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/geoshapes@master] add mock property to DB configuration

https://gerrit.wikimedia.org/r/668185

gerritbot added a project: Patch-For-Review.Mar 3 2021, 8:00 PM
gerritbot added a comment.Mar 4 2021, 9:37 AM

Change 668185 merged by jenkins-bot:
[mediawiki/services/geoshapes@master] add mock property to DB configuration

https://gerrit.wikimedia.org/r/668185

MSantos mentioned this in rMSGE5e1e0ecd72c7: add mock property to DB configuration.Mar 4 2021, 9:56 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 10:10 AM
MSantos updated the task description. (Show Details)Mar 9 2021, 4:50 PM
MSantos triaged this task as Medium priority.Mar 16 2021, 2:52 PM
MSantos moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.
MSantos moved this task from Upcoming to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Jun 23 2021, 2:02 PM
MSantos moved this task from All map-related tasks to Geoshapes on the Maps board.Sep 9 2021, 3:48 PM
MSantos edited projects, added Maps (Geoshapes); removed Maps.
Jdforrester-WMF closed this task as Declined.Mar 6 2026, 7:41 PM
Jdforrester-WMF subscribed.

Codebase is being archived, see T418372.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits