| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T171713 Make QuitKeyboardInterrupt errors unified and disable traceback in scripts | |||
| Open | None | T196851 Evaluate BaseBot class usage across scripts | |||
| Open | None | T276348 implement treat method in clean_sandbox.py |
Event Timeline
@Xqt Could you please tell me more about this issue ? I can't understand the issue and how to solve it from the description. Thanks !
This is not a trivial issue. bot.BaseBot provides a treat method which gets a page object as parameter and should do all necessary changes in it. The generic bot.BaseBot.run() method runs through a generator and calls treat for each page object. This task is about:
- devide SandboxBot.run() method into several parts that the generic bot.BaseBot.run() can be used instead - or inherit main parts from it
- move the code parts of the inner loop for each page object to` treat` or treat_page method
- page filtering may be done by skip_page method
- initializing codes should be moved to a init_page method
- there are other method like setup and teardown to be used
- find a way for the generator doing the infinite loop
Please refer bot.BaseBot methods and also the subclasses classes SingleSiteBot, MultipleSitesBot, AutomaticTWSummaryBot, ExistingPageBot for more Information. Probable split improvements into several steps.
Oo, this task seems a little bit difficult for me as I am just starting to understand the project and it's codebase. Can you recommend some issues which I can take up ? Thanks!
Look for good-first-tasks, e.g. https://phabricator.wikimedia.org/maniphest/query/aGXex1eJlF4M/#R