Page MenuHomePhabricator

PHP Notice: Undefined index: timestamp
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.36.0-wmf.33

message
PHP Notice: Undefined index: timestamp

Impact

Over 160 of these after train moved to group1 an hour or so ago. Not sure if it's user-visible.

Notes

Details

Request ID
YD@4pFCJ8R6rF9ZaR9EwawAAAIw
Request URL
https://commons.wikimedia.org/w/index.php?title=Special:MediaSearch&q=Tsai%20Ing-wen+deepcat:%22Tsai_Ing-wen%22
Stack Trace
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.33/extensions/WikibaseMediaInfo/src/Special/SpecialMediaSearch.php(181)
#0 /srv/mediawiki/php-1.36.0-wmf.33/extensions/WikibaseMediaInfo/src/Special/SpecialMediaSearch.php(181): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 [internal function]: Wikibase\MediaInfo\Special\SpecialMediaSearch->Wikibase\MediaInfo\Special\{closure}(array)
#2 /srv/mediawiki/php-1.36.0-wmf.33/extensions/WikibaseMediaInfo/src/Special/SpecialMediaSearch.php(274): array_map(Closure, array)
#3 /srv/mediawiki/php-1.36.0-wmf.33/includes/specialpage/SpecialPage.php(645): Wikibase\MediaInfo\Special\SpecialMediaSearch->execute(NULL)
#4 /srv/mediawiki/php-1.36.0-wmf.33/includes/specialpage/SpecialPageFactory.php(1383): SpecialPage->run(NULL)
#5 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(309): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#6 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(925): MediaWiki->performRequest()
#7 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(547): MediaWiki->main()
#8 /srv/mediawiki/php-1.36.0-wmf.33/index.php(53): MediaWiki->run()
#9 /srv/mediawiki/php-1.36.0-wmf.33/index.php(46): wfIndexMain()
#10 /srv/mediawiki/w/index.php(3): require(string)
#11 {main}

Event Timeline

@Umherirrender indeed, that issue was resolved by the latter patch. What do I need to do to help get this resolved?

The fix could be cherry-picked to branch wmf/1.36.0-wmf.33 and the bug added to the commit message to link to here.
Than the fix is backported and could be merged and deployed by someone with the necessary rights.

@Umherirrender indeed, that issue was resolved by the latter patch. What do I need to do to help get this resolved?

I pinged you on IRC. I'm happy to help you get it deployed.

We're co-ordinating on IRC. @Urbanecm is gonna help. Patch is ready.

Change 668147 had a related patch set uploaded (by Urbanecm; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.33] Also requet timestamp|snippet from non-page results

https://gerrit.wikimedia.org/r/668147

Change 668147 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.33] Also requet timestamp|snippet from non-page results

https://gerrit.wikimedia.org/r/668147

Mentioned in SAL (#wikimedia-operations) [2021-03-03T19:14:20Z] <urbanecm@deploy1002> Synchronized php-1.36.0-wmf.33/extensions/WikibaseMediaInfo/src/Special/SpecialMediaSearch.php: b741dc32c59700cb0cdcd82f2d951cf993679689: Also requet timestamp|snippet from non-page results (T271174; T276353) (duration: 01m 09s)

Fix deployed. Leaving open per Martin to monitor logs.

RhinosF1 lowered the priority of this task from Unbreak Now! to Needs Triage.EditedMar 4 2021, 1:59 PM

Lowering from Unbreak! but leaving open as it's no longer blocking the train but not sure if anything left to follow up. Added the task that caused it as a parent.