Wikidata Query Builder: replace vue-cli with vite and webpack with rollup
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Ladsgroup
	Mar 3 2021, 5:26 PM

Description

Our dependency graph is crazy. In order to reduce our dependencies to make security reviews easier, we should use Vite and Rollup instead.

Details

Subject	Repo	Branch	Lines +/-
Migration of vue-cli/webpack to vite/rollup	wikidata/query-builder	master	+7 K -11 K
Update toolforge cron to use the build repo	wikidata/query-builder	master	+4 -6
[Very WIP] Migrate to vite	wikidata/query-builder	master	+963 -1

Customize query in gerrit

Related Objects

Mentioned In: T288551: Investigate replacing vue-cli with vite and webpack with rollup for Toolhub
T273020: Security Readiness Review For Toolhub
T288466: [QS-GUI] Port Wikidata Query UI to a modern build system
T235498: Share Storybook Config
T264822: (MS 7) Security Readiness Review For Wikidata Query Builder
T279108: Introduce a Front-end Build Step for MediaWiki Skins and Extensions
Mentioned Here: T272879: Migrate WVUI library to Rollup or Vite

Event Timeline

Ladsgroup created this task.Mar 3 2021, 5:26 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 3 2021, 5:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This might be useful: https://wildermuth.com/2021/01/10/Vite-for-Existing-Vue-CLI-Projects

Also see T272879: Migrate WVUI library to Rollup or Vite

sbassett mentioned this in T279108: Introduce a Front-end Build Step for MediaWiki Skins and Extensions.Apr 8 2021, 8:08 PM

WMDE-leszek subscribed.Apr 9 2021, 6:57 AM

Setting to medium for now. While it certainly would be nice to have, it won't change much for the current hike anymore. However, the learning from seeing if it can be made to work with vue2 could be useful for future projects.

The priority would be raised if the sec-team has a problem with the large amount of dependencies that comes with vue-cli (+webpack).

Michael moved this task from Incoming to Backlog on the Wikidata Query Builder board.Apr 9 2021, 11:28 AM

Ladsgroup mentioned this in T264822: (MS 7) Security Readiness Review For Wikidata Query Builder.Jun 29 2021, 12:05 PM

Manuel added a project: Wikidata-Campsite.Jul 7 2021, 9:03 AM

Manuel moved this task from Incoming to Needs Wikidata PM Work on the Wikidata-Campsite board.

Manuel subscribed.

Manuel moved this task from Needs Wikidata PM Work to Unconnected Stories on the Wikidata-Campsite board.Jul 7 2021, 9:26 AM

We may need https://github.com/underfin/vite-plugin-vue2 and also maybe see https://github.com/vitejs/vite/issues/305 for background discussions.

As I understand it, the wmf teams are using vite and vue2, right? We should have a look at their setup.

Lucas_Werkmeister_WMDE set the point value for this task to 8.Jul 7 2021, 10:26 AM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jul 7 2021, 10:58 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 7 2021, 11:16 AM

Change 703870 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[wikidata/query-builder@master] [Very WIP] Migrate to vite

https://gerrit.wikimedia.org/r/703870

gerritbot added a project: Patch-For-Review.Jul 9 2021, 7:24 PM

• bete claimed this task.Jul 14 2021, 2:39 PM

• bete moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 705353 had a related patch set uploaded (by Bereket teshome; author: Bereket teshome):

[wikidata/query-builder@master] Migration of vue-cli/webpack to vite/rollup

https://gerrit.wikimedia.org/r/705353

• bete moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 23 2021, 8:32 AM

Tarrow renamed this task from Replace vue-cli with vite and webpack with rollup to Wikidata Query Builder: replace vue-cli with vite and webpack with rollup.Jul 27 2021, 9:03 AM

Tarrow mentioned this in T235498: Share Storybook Config.

Change 703870 abandoned by Ladsgroup:

[wikidata/query-builder@master] [Very WIP] Migrate to vite

Reason:

In favor of I6bd9d9f5ad59945

https://gerrit.wikimedia.org/r/703870

Change 705353 merged by jenkins-bot:

[wikidata/query-builder@master] Migration of vue-cli/webpack to vite/rollup

https://gerrit.wikimedia.org/r/705353

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 29 2021, 4:59 AM

Change 708651 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[wikidata/query-builder@master] Update toolforge cron to use the build repo