Page MenuHomePhabricator

Avoid using User ::isBlocked, ::isBlockedFrom, ::blockedFor, ::isBlockedFromCreateAccount
Open, MediumPublic

Description

User::isBlocked, User::isBlockedFrom, User::blockedFor were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions and skins:

WMF deployed

  • extensions / Wikibase
  • extensions / CodeReview
  • extensions / UrlShortener
  • extensions / OAuth
  • extensions / VisualEditor
  • extensions / Renameuser
  • extensions / NewUserMessage
  • extensions / GWToolset
  • extensions / Babel

not WMF deployed

  • extensions / SocialProfile
  • extensions / Survey
  • extensions / ArticleFeedbackv5
  • extensions / WikiLexicalData
  • extensions / Comments
  • extensions / PollNY
  • extensions / RegexBlock
  • extensions / LinkFilter
  • extensions / UserStatus
  • extensions / EditAccount
  • extensions / MassEditRegex
  • extensions / MediaWikiChat
  • extensions / Report
  • extensions / Translate
  • extensions / BlogPage
  • extensions / BlueSpiceEchoConnector
  • extensions / InteractiveBlockMessage
  • extensions / Challenge
  • extensions / GraphViz
  • extensions / HAWelcome
  • extensions / ImportFreeImages
  • extensions / LastUserLogin
  • extensions / LDAPSyncAll
  • extensions / Maintenance
  • extensions / NewUserActions
  • extensions / PageForms
  • extensions / Patroller
  • extensions / Petition
  • extensions / Poll
  • extensions / PrivateDomains
  • extensions / QuizGame
  • extensions / RefreshSpecial
  • extensions / RevisionCommentSupplement
  • extensions / SiteSettings
  • extensions / TinyMCE
  • extensions / WikiForum
  • extensions / Form
  • extensions / ConfirmAccount
  • skins / Nimbus

https://codesearch.wmcloud.org/search/?q=%5Cb(isBlocked%7CisBlockedFrom%7CblockedFor%7CisBlockedFromCreateAccount)%5Cb&i=nope&files=%5C.php&excludeFiles=&repos=

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
DeclinedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
OpenNone
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

11. ImportUsers
22. GroupsSidebar
33. SemanticPageSeries
44. MarkAsHelpful
55. SportsTeams
66. OpenID

Change 856051 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageAuthors@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856051

Change 856052 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MarkAsHelpful@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856052

Change 856053 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856053

Change 856054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlockInactive@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856054

Change 856055 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SportsTeams@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856055

Change 856056 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LDAPSyncAll@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856056

Change 856057 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cargo@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856057

Change 856058 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] article: Replace deprecated User::isBlockedFrom

https://gerrit.wikimedia.org/r/856058

How to replace User::isBlockedFromCreateAccount? It's returns a Block object and that is used in some code paths. The replacement by Authority does not return a block, it needs to get it from the PermissionStatus.
But for the WikimediaEvent extension User::isBlockedFromCreateAccount is called from a hook called by PermissionManager. Calling the permission manager to get the block in this situation can result in a loop.

Change 856058 merged by jenkins-bot:

[mediawiki/core@master] article: Replace deprecated User::isBlockedFrom

https://gerrit.wikimedia.org/r/856058

Change 856057 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856057

Change 856055 merged by jenkins-bot:

[mediawiki/extensions/SportsTeams@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856055

Change 856052 merged by jenkins-bot:

[mediawiki/extensions/MarkAsHelpful@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856052

Change 856056 merged by jenkins-bot:

[mediawiki/extensions/LDAPSyncAll@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856056

Change 856051 merged by jenkins-bot:

[mediawiki/extensions/PageAuthors@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856051

Change 856053 merged by Umherirrender:

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856053

Change 856054 merged by jenkins-bot:

[mediawiki/extensions/BlockInactive@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856054