Page MenuHomePhabricator

Avoid using User ::isBlocked, ::isBlockedFrom, ::blockedFor, ::isBlockedFromCreateAccount
Open, MediumPublic

Description

User::isBlocked, User::isBlockedFrom, User::blockedFor were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions and skins:

WMF deployed

  • extensions / Wikibase
  • extensions / CodeReview
  • extensions / UrlShortener
  • extensions / OAuth
  • extensions / VisualEditor
  • extensions / Renameuser
  • extensions / NewUserMessage
  • extensions / GWToolset
  • extensions / Babel

not WMF deployed

  • extensions / SocialProfile
  • extensions / Survey
  • extensions / ArticleFeedbackv5
  • extensions / WikiLexicalData
  • extensions / Comments
  • extensions / PollNY
  • extensions / RegexBlock
  • extensions / LinkFilter
  • extensions / UserStatus
  • extensions / EditAccount
  • extensions / MassEditRegex
  • extensions / MediaWikiChat
  • extensions / Report
  • extensions / Translate
  • extensions / BlogPage
  • extensions / BlueSpiceEchoConnector
  • extensions / InteractiveBlockMessage
  • extensions / Challenge
  • extensions / GraphViz
  • extensions / HAWelcome
  • extensions / ImportFreeImages
  • extensions / LastUserLogin
  • extensions / LDAPSyncAll
  • extensions / Maintenance
  • extensions / NewUserActions
  • extensions / PageForms
  • extensions / Patroller
  • extensions / Petition
  • extensions / Poll
  • extensions / PrivateDomains
  • extensions / QuizGame
  • extensions / RefreshSpecial
  • extensions / RevisionCommentSupplement
  • extensions / SiteSettings
  • extensions / TinyMCE
  • extensions / WikiForum
  • extensions / Form
  • extensions / ConfirmAccount
  • skins / Nimbus

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
OpenNone
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
DeclinedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
OpenVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik
ResolvedVlad.shapik

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

I don't really know how much value there is in creating a task with so many projects and subscribers. One task per project would probably get more response from maintainers.

I don't really know how much value there is in creating a task with so many projects and subscribers. One task per project would probably get more response from maintainers.

I chosed one group of methods and create the appropriate task where I tagged all extensions which use these methods. But I could create one ticket for each extension, skin or for five extensions, skins. So we will have several tickets with one main goal. What do you think @Aklapper ?

In an ideal world, I'd prefer one task per codebase as it allows different assignees and tracking progress via each task's "Status" field and easier tracking of the patch-task relation, and these tasks ideally are subtasks of a parent, MediaWiki-Core removal task. My two cents. :)

In an ideal world, I'd prefer one task per codebase as it allows different assignees and tracking progress via each task's "Status" field and easier tracking of the patch-task relation, and these tasks ideally are subtasks of a parent, MediaWiki-Core removal task. My two cents. :)

We've been mostly using checklists for this kind of work in PET, cause usually each deprecated method is used in like 20 extensions, so making a subtask per extension seems like too much overhead when patches are usually take just a few minutes to create/review. This is a compromise.

BTW, If we were able to mass-create tasks from code search results, that would be a game changing feature..

BTW, If we were able to mass-create tasks from code search results, that would be a game changing feature..

https://git.legoktm.com/legoktm/bin/src/master/codesearch2phab.py

I suppose I should turn that into a real tool now.

Change 670556 had a related patch set uploaded (by Artrix; owner: Artrix):
[mediawiki/extensions/Newsletter@master] Avoid using User::isBlocked()

https://gerrit.wikimedia.org/r/670556

This comment was removed by Vlad.shapik.

Change 670556 abandoned by Artrix:
[mediawiki/extensions/Newsletter@master] Avoid using User::isBlocked()

Reason:
Wait untill the authority project is done to make this change

https://gerrit.wikimedia.org/r/670556

Zabe triaged this task as Medium priority.Mar 14 2021, 3:05 PM

11. ImportUsers
22. GroupsSidebar
33. SemanticPageSeries
44. MarkAsHelpful
55. SportsTeams
66. OpenID