Page MenuHomePhabricator
Create Task
Maniphest T276371

Avoid using User ::isBlocked, ::isBlockedFrom, ::blockedFor, ::isBlockedFromCreateAccount
Closed, ResolvedPublic
Actions

Description

User::isBlocked, User::isBlockedFrom, User::blockedFor were soft deprecated and now need to be hard deprecated. So we need to remove using from the extensions and skins:

WMF deployed

  • extensions / Wikibase
  • extensions / CodeReview
  • extensions / UrlShortener
  • extensions / OAuth
  • extensions / VisualEditor
  • extensions / Renameuser
  • extensions / NewUserMessage
  • extensions / GWToolset
  • extensions / Babel

not WMF deployed

  • extensions / SocialProfile
  • extensions / Survey
  • extensions / ArticleFeedbackv5
  • extensions / WikiLexicalData
  • extensions / Comments
  • extensions / PollNY
  • extensions / RegexBlock
  • extensions / LinkFilter
  • extensions / UserStatus
  • extensions / EditAccount
  • extensions / MassEditRegex
  • extensions / MediaWikiChat
  • extensions / Report
  • extensions / Translate
  • extensions / BlogPage
  • extensions / BlueSpiceEchoConnector
  • extensions / InteractiveBlockMessage
  • extensions / Challenge
  • extensions / GraphViz
  • extensions / HAWelcome
  • extensions / ImportFreeImages
  • extensions / LastUserLogin
  • extensions / LDAPSyncAll
  • extensions / Maintenance
  • extensions / NewUserActions
  • extensions / PageForms
  • extensions / Patroller
  • extensions / Petition
  • extensions / Poll
  • extensions / PrivateDomains
  • extensions / QuizGame
  • extensions / RefreshSpecial
  • extensions / RevisionCommentSupplement
  • extensions / SiteSettings
  • extensions / TinyMCE
  • extensions / WikiForum
  • extensions / Form
  • extensions / ConfirmAccount
  • skins / Nimbus

https://codesearch.wmcloud.org/search/?q=%5Cb(isBlocked%7CisBlockedFrom%7CblockedFor%7CisBlockedFromCreateAccount)%5Cb&i=nope&files=%5C.php&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Replace deprecated User::isBlockedmediawiki/extensions/BlockInactivemaster+2 -2
Replace deprecated User::isBlockedmediawiki/extensions/BlueSpiceFoundationmaster+1 -1
Replace deprecated User::isBlockedmediawiki/extensions/PageAuthorsmaster+1 -1
Replace deprecated User::isBlockedmediawiki/extensions/LDAPSyncAllmaster+7 -6
Replace deprecated User::isBlockedmediawiki/extensions/MarkAsHelpfulmaster+1 -1
Replace deprecated User::isBlockedmediawiki/extensions/SportsTeamsmaster+2 -2
Replace deprecated User::isBlockedmediawiki/extensions/Cargomaster+3 -3
article: Replace deprecated User::isBlockedFrommediawiki/coremaster+1 -1
Avoid using User::isBlocked()mediawiki/extensions/Newslettermaster+6 -4
Avoid using User::isBlockedmediawiki/extensions/Echomaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release
 OpenNoneT274211 Finish hard-deprecation and removal of User methods depecated prior to MW 1.36
 ResolvedNoneT276371 Avoid using User ::isBlocked, ::isBlockedFrom, ::blockedFor, ::isBlockedFromCreateAccount
 ResolvedVlad.shapikT291378 extensions/Wikibase - replace the block-related methods
 ResolvedVlad.shapikT291838 extensions/SocialProfile - replace the block-related methods
 ResolvedVlad.shapikT291844 extensions/Survey - replace the block-related methods
 ResolvedVlad.shapikT291845 extensions/ArticleFeedbackv5 - replace the block-related methods
 ResolvedVlad.shapikT291922 extensions/WikiLexicalData - replace the block-related methods
 ResolvedVlad.shapikT291923 extensions/Comments - replace the block-related methods
 ResolvedVlad.shapikT291924 extensions/PollNY - replace the block-related methods
 ResolvedVlad.shapikT291926 extensions/RegexBlock - replace the block-related methods
 DeclinedVlad.shapikT291927 extensions/Answers - replace the block-related methods
 ResolvedVlad.shapikT292689 extensions/CodeReview - replace the block-related methods
 ResolvedVlad.shapikT294111 extensions/OAuth - replace the block-related methods
 ResolvedVlad.shapikT294123 extensions/Babel - replace the block-related methods
 ResolvedVlad.shapikT294201 extensions/UrlShortener - replace the block-related methods
 ResolvedVlad.shapikT294226 extensions/QuizGame - replace the block-related methods
 ResolvedVlad.shapikT294227 extensions/PrivateDomains - replace the block-related methods
 ResolvedVlad.shapikT294232 extensions/Poll - replace the block-related methods
 ResolvedVlad.shapikT294233 extensions/Petition - replace the block-related methods
 ResolvedVlad.shapikT294235 extensions/Patroller - replace the block-related methods
 ResolvedVlad.shapikT294237 extensions/PageForms - replace the block-related methods
 ResolvedVlad.shapikT294242 extensions/NewUserActions - replace the block-related methods
 ResolvedVlad.shapikT294247 extensions/Maintenance - replace the block-related methods
 ResolvedVlad.shapikT294248 extensions/LDAPSyncAll - replace the block-related methods
 ResolvedVlad.shapikT294250 extensions/LastUserLogin - replace the block-related methods
 ResolvedVlad.shapikT294252 extensions/GraphViz - replace the block-related methods
 ResolvedVlad.shapikT294253 extensions/InteractiveBlockMessage - replace the block-related methods
 ResolvedVlad.shapikT294266 extensions/ImportFreeImages - replace the block-related methods
 ResolvedVlad.shapikT294268 extensions/HAWelcome - replace the block-related methods
 ResolvedVlad.shapikT294269 extensions/Challenge - replace the block-related methods
 ResolvedVlad.shapikT294277 extensions/BlueSpiceEchoConnector - replace the block-related methods
 ResolvedVlad.shapikT294278 extensions/BlogPage - replace the block-related methods
 ResolvedVlad.shapikT294279 extensions/Translate - replace the block-related methods
 ResolvedVlad.shapikT294282 extensions/Report - replace the block-related methods
 ResolvedVlad.shapikT294284 extensions/MediaWikiChat - replace the block-related methods
 ResolvedVlad.shapikT294285 extensions/MassEditRegex - replace the block-related methods
 ResolvedVlad.shapikT294290 extensions/EditAccount - replace the block-related methods
 ResolvedVlad.shapikT294292 extensions/UserStatus - replace the block-related methods
 ResolvedVlad.shapikT294293 extensions/LinkFilter - replace the block-related methods
 ResolvedVlad.shapikT294374 extensions/NewUserMessage - replace the block-related methods
 ResolvedVlad.shapikT294376 extensions/Renameuser - replace the block-related methods
 ResolvedVlad.shapikT294808 extensions/GWToolset- replace the block-related methods
 ResolvedVlad.shapikT294809 extensions/RefreshSpecial - replace the block-related methods
 ResolvedVlad.shapikT294813 extensions/SiteSettings - replace the block-related methods
 ResolvedVlad.shapikT294823 extensions/VisualEditor - replace the block-related methods
 ResolvedVlad.shapikT295139 extensions/WikiForum - replace the block-related methods
 OpenNoneT295145 extensions/ConfirmAccount - replace the block-related methods
 ResolvedVlad.shapikT295146 extensions/TinyMCE - replace the block-related methods
 ResolvedVlad.shapikT295222 extensions/Form - replace the block-related methods
 ResolvedVlad.shapikT295256 extensions/RevisionCommentSupplement - replace the block-related methods
 ResolvedVlad.shapikT295575 skins/Nimbus - replace the block-related methods

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Vlad.shapik updated the task description. (Show Details)Oct 26 2021, 1:51 PM
Vlad.shapik updated the task description. (Show Details)Oct 26 2021, 1:55 PM
Kizule closed subtask T294290: extensions/EditAccount - replace the block-related methods as Resolved.Oct 26 2021, 3:40 PM
Vlad.shapik updated the task description. (Show Details)Oct 26 2021, 6:00 PM
Vlad.shapik updated the task description. (Show Details)Oct 28 2021, 3:26 PM
Vlad.shapik updated the task description. (Show Details)Oct 28 2021, 6:36 PM
Vlad.shapik updated the task description. (Show Details)Oct 29 2021, 11:13 AM
Vlad.shapik updated the task description. (Show Details)Oct 29 2021, 11:41 AM
Vlad.shapik updated the task description. (Show Details)Nov 1 2021, 12:33 PM
Vlad.shapik updated the task description. (Show Details)Nov 2 2021, 10:51 AM
Vlad.shapik updated the task description. (Show Details)Nov 5 2021, 9:34 AM
Vlad.shapik updated the task description. (Show Details)Nov 5 2021, 1:15 PM
ArTrix unsubscribed.Nov 9 2021, 11:56 AM
Vlad.shapik updated the task description. (Show Details)Nov 12 2021, 8:59 AM
Vlad.shapik updated the task description. (Show Details)Nov 12 2021, 9:28 AM
Vlad.shapik updated the task description. (Show Details)Nov 12 2021, 3:50 PM
Vlad.shapik updated the task description. (Show Details)Nov 15 2021, 5:33 PM
Vlad.shapik closed subtask T295575: skins/Nimbus - replace the block-related methods as Resolved.Nov 29 2021, 9:45 AM
Vlad.shapik closed subtask T292689: extensions/CodeReview - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291922: extensions/WikiLexicalData - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T295222: extensions/Form - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291923: extensions/Comments - replace the block-related methods as Resolved.Nov 29 2021, 9:47 AM
Vlad.shapik closed subtask T291924: extensions/PollNY - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294123: extensions/Babel - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294237: extensions/PageForms - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294282: extensions/Report - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291378: extensions/Wikibase - replace the block-related methods as Resolved.Nov 29 2021, 9:50 AM
Vlad.shapik closed subtask T294201: extensions/UrlShortener - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294278: extensions/BlogPage - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294269: extensions/Challenge - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294268: extensions/HAWelcome - replace the block-related methods as Resolved.Nov 29 2021, 9:52 AM
Vlad.shapik closed subtask T294293: extensions/LinkFilter - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294292: extensions/UserStatus - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294227: extensions/PrivateDomains - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294226: extensions/QuizGame - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291838: extensions/SocialProfile - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294247: extensions/Maintenance - replace the block-related methods as Resolved.Nov 29 2021, 9:55 AM
Vlad.shapik closed subtask T294232: extensions/Poll - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294233: extensions/Petition - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294235: extensions/Patroller - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294285: extensions/MassEditRegex - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294252: extensions/GraphViz - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294284: extensions/MediaWikiChat - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294277: extensions/BlueSpiceEchoConnector - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294266: extensions/ImportFreeImages - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294242: extensions/NewUserActions - replace the block-related methods as Resolved.Nov 29 2021, 9:57 AM
Vlad.shapik closed subtask T294248: extensions/LDAPSyncAll - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294250: extensions/LastUserLogin - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294253: extensions/InteractiveBlockMessage - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294111: extensions/OAuth - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294279: extensions/Translate - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294376: extensions/Renameuser - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294808: extensions/GWToolset- replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294813: extensions/SiteSettings - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294374: extensions/NewUserMessage - replace the block-related methods as Resolved.Nov 29 2021, 9:59 AM
Vlad.shapik closed subtask T294823: extensions/VisualEditor - replace the block-related methods as Resolved.Nov 29 2021, 12:16 PM
Vlad.shapik closed subtask T295256: extensions/RevisionCommentSupplement - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T295139: extensions/WikiForum - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291926: extensions/RegexBlock - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T294809: extensions/RefreshSpecial - replace the block-related methods as Resolved.Nov 29 2021, 12:18 PM
Vlad.shapik closed subtask T295146: extensions/TinyMCE - replace the block-related methods as Resolved.
Vlad.shapik closed subtask T291844: extensions/Survey - replace the block-related methods as Resolved.
Vlad.shapik removed Vlad.shapik as the assignee of this task.Dec 1 2021, 7:03 PM
daniel moved this task from Doing to UserStore pile on the Platform Team Workboards (MW Expedition) board.May 24 2022, 8:18 AM
gerritbot added a comment.Nov 12 2022, 9:27 PM

Change 856051 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PageAuthors@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856051

gerritbot added a project: Patch-For-Review.Nov 12 2022, 9:27 PM
gerritbot added a comment.Nov 12 2022, 9:29 PM

Change 856052 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MarkAsHelpful@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856052

gerritbot added a comment.Nov 12 2022, 9:30 PM

Change 856053 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856053

gerritbot added a comment.Nov 12 2022, 9:32 PM

Change 856054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BlockInactive@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856054

gerritbot added a comment.Nov 12 2022, 9:33 PM

Change 856055 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/SportsTeams@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856055

gerritbot added a comment.Nov 12 2022, 9:35 PM

Change 856056 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LDAPSyncAll@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856056

gerritbot added a comment.Nov 12 2022, 9:37 PM

Change 856057 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cargo@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856057

Umherirrender updated the task description. (Show Details)Nov 12 2022, 9:38 PM
gerritbot added a comment.Nov 12 2022, 9:44 PM

Change 856058 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] article: Replace deprecated User::isBlockedFrom

https://gerrit.wikimedia.org/r/856058

Umherirrender subscribed.Nov 12 2022, 10:00 PM

How to replace User::isBlockedFromCreateAccount? It's returns a Block object and that is used in some code paths. The replacement by Authority does not return a block, it needs to get it from the PermissionStatus.
But for the WikimediaEvent extension User::isBlockedFromCreateAccount is called from a hook called by PermissionManager. Calling the permission manager to get the block in this situation can result in a loop.

gerritbot added a comment.Nov 14 2022, 9:33 AM

Change 856058 merged by jenkins-bot:

[mediawiki/core@master] article: Replace deprecated User::isBlockedFrom

https://gerrit.wikimedia.org/r/856058

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 14 2022, 10:00 AM
gerritbot added a comment.Nov 14 2022, 2:54 PM

Change 856057 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856057

gerritbot added a comment.Nov 22 2022, 8:47 PM

Change 856055 merged by jenkins-bot:

[mediawiki/extensions/SportsTeams@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856055

gerritbot added a comment.Nov 22 2022, 8:49 PM

Change 856052 merged by jenkins-bot:

[mediawiki/extensions/MarkAsHelpful@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856052

gerritbot added a comment.Nov 22 2022, 8:49 PM

Change 856056 merged by jenkins-bot:

[mediawiki/extensions/LDAPSyncAll@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856056

Umherirrender mentioned this in rEMAHfcec0e2c3857: Replace deprecated User::isBlocked.Nov 22 2022, 8:49 PM
Umherirrender mentioned this in rELSA7ae4e3bcaadf: Replace deprecated User::isBlocked.Nov 22 2022, 8:52 PM
gerritbot added a comment.Nov 22 2022, 9:04 PM

Change 856051 merged by jenkins-bot:

[mediawiki/extensions/PageAuthors@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856051

Umherirrender mentioned this in rEPAU257d0cfd808d: Replace deprecated User::isBlocked.Nov 22 2022, 9:05 PM
gerritbot added a comment.Nov 22 2022, 9:10 PM

Change 856053 merged by Umherirrender:

[mediawiki/extensions/BlueSpiceFoundation@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856053

gerritbot added a comment.Nov 22 2022, 9:12 PM

Change 856054 merged by jenkins-bot:

[mediawiki/extensions/BlockInactive@master] Replace deprecated User::isBlocked

https://gerrit.wikimedia.org/r/856054

Umherirrender mentioned this in rEBINa8aaa19bbc02: Replace deprecated User::isBlocked.Nov 22 2022, 9:13 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 22 2022, 9:30 PM
Umherirrender added a comment.Dec 20 2022, 8:36 PM

For me the code search looks like only User::isBlockedFromCreateAccount remains, that replacement feels harder to do, because the function is not to inline.

Should be removed from this task, it is still listed on T277511 to keep it in mind.

Umherirrender mentioned this in T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Dec 20 2022, 8:48 PM
Umherirrender added a comment.Dec 20 2022, 9:03 PM

https://github.com/SemanticMediaWiki/SemanticWatchlist/issues/97

Umherirrender moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 9:18 PM
gerritbot added a comment.Aug 8 2023, 1:14 PM

Change 946946 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Drop User::blockedFor() and AbstractBlock::getReason(), deprecated in 1.35

https://gerrit.wikimedia.org/r/946946

gerritbot added a project: Patch-For-Review.Aug 8 2023, 1:14 PM
Jdforrester-WMF closed this task as Resolved.Sep 21 2023, 6:52 PM
Jdforrester-WMF subscribed.

This is as done as it will get. Closing.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL