Page MenuHomePhabricator

Remove #Patch-For-Review when patch is abandoned in Gerrit
Closed, ResolvedPublic

Description

When some a patch gets uploaded, @gerritbot adds the Patch-For-Review tag. @Maintenance_bot removes the tag, when the patch gets merged, but not when the patch gets abandoned. Thus there are tasks with the tag, but without actually having patches for review (e.g. T275819).

Would it be possible to remove the tag also when the patch is abandoned?

Event Timeline

Aklapper renamed this task from Remove Patch for review when patch is abandoned to Remove #Patch-For-Review when patch is abandoned in Gerrit.Mar 4 2021, 10:02 AM
Aklapper updated the task description. (Show Details)

The code at least in paper supports abandoned patches too: https://github.com/Ladsgroup/Phabricator-maintenance-bot/blob/master/patchforreview_remover.py#L43

Might be that the formatting of the message changed? I'll check.