Page MenuHomePhabricator
Create Task
Maniphest T276430

Move WikibaseRepo StringNormalizer to service container
Closed, ResolvedPublic
Actions

Description

It’s buried somewhere in the entity source services / generic services, but actually it’s a trivial service that can probably be moved to the service container without trouble.

See also T276431.

Details

SubjectRepoBranchLines +/-
Update WikibaseRepo::getStringNormalizer() callsmediawiki/extensions/WikibaseLexememaster+19 -11
Update WikibaseRepo::getStringNormalizer() callmediawiki/extensions/Scoremaster+1 -2
Update WikibaseRepo::getStringNormalizer() callmediawiki/extensions/MathSearchmaster+1 -2
Update WikibaseRepo::getStringNormalizer() callmediawiki/extensions/Mathmaster+1 -2
repo: move StringNormalizer to service containermediawiki/extensions/Wikibasemaster+45 -21
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 4 2021, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 4 2021, 10:03 AM
Lucas_Werkmeister_WMDE mentioned this in T276431: Move WikibaseClient StringNormalizer to service container.Mar 4 2021, 10:03 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE claimed this task.Mar 4 2021, 1:13 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T276456: Move WikibaseRepo TermStoreWriterFactory to service container.Mar 4 2021, 1:32 PM
gerritbot added a comment.Mar 4 2021, 1:38 PM

Change 668418 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: move StringNormalizer to service container

https://gerrit.wikimedia.org/r/668418

gerritbot added a project: Patch-For-Review.Mar 4 2021, 1:38 PM

Change 668419 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/MathSearch@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668419

gerritbot added a comment.Mar 4 2021, 1:39 PM

Change 668420 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Math@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668420

gerritbot added a comment.Mar 4 2021, 1:39 PM

Change 668421 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Score@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668421

gerritbot added a comment.Mar 4 2021, 1:39 PM

Change 668422 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getStringNormalizer() calls

https://gerrit.wikimedia.org/r/668422

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 4 2021, 1:39 PM
Lucas_Werkmeister_WMDE mentioned this in T276457: Move WikibaseRepo LanguageFallbackChainFactory to service container.Mar 4 2021, 2:16 PM
Lucas_Werkmeister_WMDE mentioned this in T276531: Remove StringNormalizer from WikibaseServices.Mar 5 2021, 10:32 AM
Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 5 2021, 12:18 PM
gerritbot added a comment.Mar 5 2021, 5:05 PM

Change 668418 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: move StringNormalizer to service container

https://gerrit.wikimedia.org/r/668418

gerritbot added a comment.Mar 5 2021, 5:05 PM

Change 668420 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668420

gerritbot added a comment.Mar 5 2021, 5:05 PM

Change 668419 merged by jenkins-bot:
[mediawiki/extensions/MathSearch@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668419

Lucas_Werkmeister_WMDE mentioned this in rEMASe1fbd76f22e1: Update WikibaseRepo::getStringNormalizer() call.Mar 5 2021, 5:25 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 5 2021, 6:00 PM
gerritbot added a comment.Mar 9 2021, 10:19 AM

Change 668421 merged by jenkins-bot:
[mediawiki/extensions/Score@master] Update WikibaseRepo::getStringNormalizer() call

https://gerrit.wikimedia.org/r/668421

gerritbot added a comment.Mar 9 2021, 11:00 AM

Change 668422 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getStringNormalizer() calls

https://gerrit.wikimedia.org/r/668422

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 11:10 AM
ItamarWMDE closed this task as Resolved.Mar 9 2021, 11:16 AM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL