Page MenuHomePhabricator

SecurePoll: TallyPage forms add label to SelectFileWidget and change order
Closed, ResolvedPublic2 Estimated Story Points

Description

The current form looks like this:

encrypted_election_tally.png (775×374 px, 23 KB)

Based on @dom_walden’s feedback on T272916 that the SelectFileWidget is getting too much attention, I propose two changes:

  • Change the order of the two fields, the GPG Key textarea first followed by SelectFileWidget
  • Add a label to the SelectFileWidget making it clear that it is optional - Upload encrypted dump (optional)

We don’t usually do this for optional form fields but I think this is a weird use-case so its alright to make it explicit. Let us keep the help text as is.

Event Timeline

Change 673072 had a related patch set uploaded (by TsepoThoabala; owner: TsepoThoabala):
[mediawiki/extensions/SecurePoll@master] SecurePoll: TallyPage forms add label to SelectFileWidget and change order

https://gerrit.wikimedia.org/r/673072

Change 673072 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] SecurePoll: TallyPage forms add label to SelectFileWidget and change order

https://gerrit.wikimedia.org/r/673072