Page MenuHomePhabricator

Proposed changes to the SRE Access request (Phabricator form 8)
Closed, ResolvedPublic

Description

The following are proposed changes to the access request. specifically i have proposed the following

  • remove preferred wikitech shell name. We should use the uid in ldap for the shell name, allowing different shell names here just causes confusion
  • reword the L3 line. We can validate the user has signed L3 via phabricator it seems superfluous to also have the user confirm on the task
  • drop Requestor -- Im not sure this adds anything
  • drop the requirement to wait 3 working days, this was agreed to some time ago but the form has never been updated
  • drop the checkbox relating to " Patchset for access request" this is already viable in phabricator
  • add a requirement to seek approval from the group Approver
  • some general rewording

Please hold of on making any changes before we have received sign of from @MoritzMuehlenhoff and one of either @mark or @faidon

== Requestor provided information and prerequisites ==

**This section is to be completed by the individual requesting access.**

* Wikitech username:
* Email address:
* SSH public key (must be a separate key from Wikimedia cloud SSH access):
* Requested group membership:
* Reason for access:
* Name of approving party (manager for WMF/WMDE staff):
* Ensure you have signed the L3 Wikimedia Server Access Responsibilities document: 
* Please coordinate obtaining a comment of approval on this task from the approving party.


== SRE Clinic Duty Confirmation Checklist for Access Requests ==

This checklist should be used on all access requests to ensure that all steps are covered, including expansion to existing access. Please double check the step has been completed before checking it off.

**This section is to be confirmed and completed by a member of the SRE team.** 

[] - User has signed the L3 Acknowledgement of Wikimedia Server Access Responsibilities Document.
[] - User has a valid NDA on file with WMF legal.  (All WMF Staff/Contractor hiring are covered by NDA.  Other users can be validated via the NDA tracking sheet)
[] - User has provided the following: wikitech username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)
[] - User has provided a public SSH key.  This ssh key pair should only be used for WMF cluster access, and not shared with any other service (this includes not sharing with WMCS access, no shared keys.)
[] - access request (or expansion) has sign off of WMF sponsor/manager (sponsor for volunteers, manager for wmf staff)
[] - access request (or expansion) has sign off of group approver indicated by the approval field in data.yaml
For additional details regarding access request requirements, please see https://wikitech.wikimedia.org/wiki/Requesting_shell_access

Event Timeline

jbond triaged this task as Medium priority.Mar 4 2021, 4:12 PM
jbond created this task.
jbond updated the task description. (Show Details)
Aklapper renamed this task from Proposed changes to the SRE Access request to Proposed changes to the SRE Access request (Phabricator form 8).Mar 6 2021, 8:56 AM

I'm happy to edit the form once this is signed off on, but unsubscribing for now until then. Once this is ready for the actual change to the form (approved the directors I suppose according to the task description, or Mortiz), then just assign this over to me.

Looks good! Some comments below:

Instead of "Ssh public key (must be dedicated key for wmf production)" let's use "SSH public key (must be a separate key from Wikimedia cloud SSH access)" ? It's a little more explicit.

Instead of "Name of approving party (hiring manager for WMF staff):" let's use "Name of approving party (manager for WMF/WMDE staff)"? (Also covers WMDE and the person's hiring manager isn't necessarily the same as the current manager (some people might only ask for shell access after a long time).

"User has provided the following: wikitech username, preferred shell username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)" -> We should drop the shell username here as well

Looks good! Some comments below:

Instead of "Ssh public key (must be dedicated key for wmf production)" let's use "SSH public key (must be a separate key from Wikimedia cloud SSH access)" ? It's a little more explicit.

Instead of "Name of approving party (hiring manager for WMF staff):" let's use "Name of approving party (manager for WMF/WMDE staff)"? (Also covers WMDE and the person's hiring manager isn't necessarily the same as the current manager (some people might only ask for shell access after a long time).

"User has provided the following: wikitech username, preferred shell username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)" -> We should drop the shell username here as well

thanks updated

jbond added a subscriber: RobH.

@RobH can we go forward with this change, with moritz approval and no objections since its been up i think we can forgo director approval (i have pinged @faidon to let him know so he can reject retrospectively if there is anything really wrong)

https://phabricator.wikimedia.org/maniphest/task/edit/form/8/ updated with whats in the body of this task description.