Page MenuHomePhabricator

Adjust VE dialog header titles
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

Currently, the dialog header titles and button text are reactive to content. We want to keep this same behavior, but adjust the text that is shown.

States

ActionCurrent TitleNew TitleMock Current Button TextNew Button Text
When inserting a new template. Shown after clicking Insert > Template, while on the search screen.Add a templateInsert a template
Screen Shot 2021-03-05 at 14.29.39.png (105×1 px, 11 KB)
Insert (disabled)no change
After choosing a new template to insert, while filling out template.{Template name}Insert: {Template name}
Screen Shot 2021-03-05 at 14.25.16.png (66×609 px, 6 KB)
Insertno change
When editing an existing transclusion already present on a page{Template name}Edit: {Template name}
Screen Shot 2021-03-05 at 14.26.21.png (66×693 px, 6 KB)
Apply changesSave
When editing an existing transclusion with multiple parts (template+wikitext or more than one template)TransclusionTemplate content
Screen Shot 2021-06-03 at 12.06.02.png (116×861 px, 13 KB)
Apply changesSave
When editing on mobile-The header titles should match the updates above. If the title is too long on mobile screens, it should be truncated.
Screen Shot 2021-03-05 at 14.42.08.png (85×288 px, 7 KB)
Checkmarkno change

Relevant prototype commits:

Event Timeline

Lena_WMDE set the point value for this task to 3.Apr 14 2021, 1:44 PM
Lena_WMDE renamed this task from DRAFT: Adjust VE dialog header titles to Adjust VE dialog header titles.Apr 14 2021, 1:50 PM

Change 686497 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] [WIP] Change header titles in the template dialog

https://gerrit.wikimedia.org/r/686497

Change 696026 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] [WIP] Update titles in the tranclusion dialog

https://gerrit.wikimedia.org/r/696026

Please confirm that we are *not* supposed to change the multipart transclusion "add a template" / "Add template" text:

image.png (217×716 px, 17 KB)

In the sidebar,

image.png (152×337 px, 6 KB)

In the initial screen

image.png (216×427 px, 10 KB)

Change 686497 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Change header titles in the template dialog

https://gerrit.wikimedia.org/r/686497

Change 697724 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Template dialog button title toggles between Insert/Edit

https://gerrit.wikimedia.org/r/697724

Change 697725 had a related patch set uploaded (by Awight; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] [WIP] Update template dialog title when multiple transclusions present

https://gerrit.wikimedia.org/r/697725

Marking "stalled" until the text is finalized, and on question about "Add template"

Change 697724 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Template dialog button title toggles between Insert/Edit

https://gerrit.wikimedia.org/r/697724

Change 696026 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update template dialog titles: Insert/Edit

https://gerrit.wikimedia.org/r/696026

Please confirm that we are *not* supposed to change the multipart transclusion "add a template" / "Add template" text:

Adding a note to say that we reviewed Adam's comment in story time: confirming that when adding additional templates to a multipart transclusion, it should say 'add a template' / 'add template.' This ticket should only adjust the dialog headers.

Also, the text has been updated and finalized. The only change is for the multi-part transclusion header. After much discussion, we've settled on simply "Template content".

So I think this can be moved out of stalled? I'll leave it for now because I'm quite sure what the correct column would be - but wanted to double check that all the loose ends are resolved.

Change 697725 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update template dialog title when multiple transclusions present

https://gerrit.wikimedia.org/r/697725

Demo'd except for the multipart header change.

Lena_WMDE changed the point value for this task from 3 to 1.

Needs to be backported.

WMDE-Fisch subscribed.

Needs to be backported.

Since we've pushed the release date, the backport it not needed anymore. Can be closed I guess @Lena_WMDE

Change 700849 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove confusing dialog header tooltip

https://gerrit.wikimedia.org/r/700849

Change 700849 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Make template dialog header tooltip match title

https://gerrit.wikimedia.org/r/700849

Change 700917 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove tooltip from template dialog title

https://gerrit.wikimedia.org/r/700917

From todays demo time:

The strange code in OOUI that was causing mismatching tooltips on the dialog's title was removed via T285310. This will probably be part of OOUI 0.41.4, which is not released yet. The cluster currently uses 0.41.3 from March 2021.

Options we have:

  • Leave the tooltip and just wait for that OOUI release. It currently always says "Template content", which doesn't match the visible title but is not wrong either.
  • While it's possible to manually update that tooltip in our code (as done in https://gerrit.wikimedia.org/r/700849), we must remove such a workaround the moment the next OOUI release is made (because there is no tooltip any more). Personally I don't think managing this Technical-Debt is worth it. As argued above: the tooltip is not terribly wrong.
  • There is one alternative patch that removes the tooltip altogether and will work with both the current and next OOUI version: https://gerrit.wikimedia.org/r/700917. The patch achieves this by removing the static default title and replacing it with the one that's dynamically updated anyway. This happens early and often enough so that users never see an empty title.

From what was said during demo time PM is fine with either option. @awight, what do you think?

  • There is one alternative patch that removes the tooltip altogether and will work with both the current and next OOUI version: https://gerrit.wikimedia.org/r/700917. The patch achieves this by removing the static default title and replacing it with the one that's dynamically updated anyway. This happens early and often enough so that users never see an empty title.

Merged, thank you for the strong follow-up!

Change 700917 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove tooltip from template dialog title

https://gerrit.wikimedia.org/r/700917