Move WikibaseRepo StatementSerializer to service container
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 5 2021, 2:23 PM

Description

Can be done after T276533: Move WikibaseRepo BaseDataModelSerializerFactory to service container.

Details

	Subject	Repo	Branch	Lines +/-
	repo: remove WikibaseRepo::getStatementSerializer()	mediawiki/extensions/Wikibase	master	+5 -15

Customize query in gerrit

Related Objects

Mentioned In: T268600: Implement services through MediaWikiServices
Mentioned Here: T276533: Move WikibaseRepo BaseDataModelSerializerFactory to service container

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 5 2021, 2:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2021, 2:23 PM

Lucas_Werkmeister_WMDE moved this task from Incoming to Waiting for other services on the Wikibase Service Migration board.Mar 5 2021, 2:23 PM

Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Mar 5 2021, 4:49 PM

Apparently this service is only used in four tests?

Maybe we shouldn’t move it at all, then, and only inline it in those tests… it just forwards to getBaseDataModelSerializerFactory()->newStatementSerializer(), anyways.

Lucas_Werkmeister_WMDE claimed this task.Mar 10 2021, 3:52 PM

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.

Change 670491 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] repo: remove WikibaseRepo::getStatementSerializer()

https://gerrit.wikimedia.org/r/670491

gerritbot added a project: Patch-For-Review.Mar 10 2021, 3:55 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 10 2021, 3:55 PM

Change 670491 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] repo: remove WikibaseRepo::getStatementSerializer()

https://gerrit.wikimedia.org/r/670491

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 11 2021, 2:47 PM

Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 11 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2021, 3:10 PM

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 16 2021, 4:27 PM