Page MenuHomePhabricator

selenium-daily-beta-CirrusSearch is failing
Closed, ResolvedPublic


The daily browser test for CirrusSearch is failing as it cannot find completion results.

It tries to find results in this path: .suggestions .suggestions-results but it no longer exists.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Jdrewniak would you be aware of a change that might have changed the way autocomplete suggestions are displayed on ?

Hi @dcausse , yes, the beta cluster was configured to use the new version of Vector (as per the desktop improvements project) as well as a new search widget that features descriptions and thumbnails.
I think the likely cause of this breakage was the new search widget. Not only does it have a totally different DOM structure than the old search widget, it also uses the search Rest API wrapper. (I'm not sure if that effects the actual results, but just something to be aware of).

If you're ok with using the new search widget, The DOM path for the suggestions would be something like #searchform-suggestions a.wvui-typeahead-suggestion to target a search suggestion link.

If however, you need to run the tests using the old search widget, you can use the old version of Vector by appending the query string ?useskinversion=1 to the URL.

Thanks @Jdrewniak!
I think I'll go with ?useskinversion=1 for now and wait for the new widget to become the default to switch to it in the test code.

Change 671082 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Force skinversion 1 for daily selenium tests

Change 671082 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Force skinversion 1 for daily selenium tests

Gehel claimed this task.