Page MenuHomePhabricator
Create Task
Maniphest T276661

Remove PopupTools, React-notifications and reactstrap and replace with Antd components
Closed, ResolvedPublic
Actions

Description

As we are using antd library in our tool let us completely remove other libraries and make our codebase clean.

So we can completely remove PopupTools, react-notifications and reactstrap libraries from our tool.

Details

SubjectRepoBranchLines +/-
Replaced components with Antd componentslabs/tools/VideoCutToolmaster+7 -11
Customize query in gerrit

Related Objects

Event Timeline

Gopavasanth created this task.Mar 6 2021, 10:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2021, 10:30 AM
Gopavasanth renamed this task from Replace PopupTools component with popover from Antd to Replace PopupTools, React-notifications components with Antd components .Mar 6 2021, 10:35 AM
Gopavasanth updated the task description. (Show Details)
Gopavasanth renamed this task from Replace PopupTools, React-notifications components with Antd components to Remove PopupTools, React-notifications and reactstrap and replace with Antd components.Mar 6 2021, 10:54 AM
Gopavasanth updated the task description. (Show Details)
Sandyabhi subscribed.EditedMar 7 2021, 3:01 PM

Hi @Gopavasanth , notification and Form from antd were done but I don't get how to use Popover from antd in place of PopupTools .

notification from antd
localhost_3000_.png (695×811 px, 35 KB)
Form from antd
localhost_3000_ (2).png (337×541 px, 11 KB)
Gopavasanth added a comment.Mar 8 2021, 4:24 PM

Hi @Sandyabhi, Nice to see your work on this task! Please feel free to create a patch-set with what you have done so far :)

Suggestion: Will it be a good idea to show a success tick (green colored) on the notification along with text in notification?

gerritbot added a comment.Mar 9 2021, 9:06 AM

Change 670099 had a related patch set uploaded (by Sandyabhi; owner: Sandyabhi):
[labs/tools/VideoCutTool@master] Replaced components with Antd components

https://gerrit.wikimedia.org/r/670099

gerritbot added a project: Patch-For-Review.Mar 9 2021, 9:06 AM
gerritbot added a comment.Mar 11 2021, 4:43 PM

Change 670099 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Replaced components with Antd components

https://gerrit.wikimedia.org/r/670099

Gopavasanth mentioned this in rLTVTd40c019e0851: Replaced components with Antd components.Mar 11 2021, 4:46 PM
Gopavasanth updated the task description. (Show Details)Mar 11 2021, 4:46 PM
Gopavasanth removed a project: Patch-For-Review.
SarthakKundra claimed this task.Mar 15 2021, 11:06 AM
Gopavasanth removed SarthakKundra as the assignee of this task.May 21 2021, 10:19 AM
Gopavasanth added a subscriber: SarthakKundra.

@SarthakKundra Feel free to reclaim again if you are planning to work on this ticket :)

rajarshi claimed this task.Nov 7 2021, 6:54 AM
Gopavasanth closed this task as Resolved.Jun 15 2022, 11:32 AM
Gopavasanth reassigned this task from rajarshi to Sandyabhi.
Gopavasanth added a subscriber: rajarshi.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL