Regression: Settings button misplaced in article preview
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Patriccck
	Mar 6 2021, 1:07 PM

Description

QA

test 1

Go here.
Try to hover over a link "Richard Genzer", you will see an article preview.
Setting button interferes with an image of Richard Genzer (see screenshot). (I think it should be shifted a little bit to left).

test 2

Go to https://en.wikipedia.org/wiki/Betty_Compson when hovering over "The Barker"

Test 3

Go to https://he.wikipedia.org/wiki/הממלכה_המאוחדת and hover over לונדון

QA Results - Beta

AC	Status	Details
1	✅	T276668#6965118

QA Results - Prod

AC	Status	Details
1	✅	T276668#6965129
2	✅	T276668#6965129
3	❌	T276668#6965129

QA Results - Prod

AC	Status	Details
1	✅	T276668#7088258
2	✅	T276668#7088258
3	❌	T276668#7088258

Details

	Subject	Repo	Branch	Lines +/-
	Fix setting button placement in article preview	mediawiki/extensions/Popups	master	+3 -0
	Set thumbnail width to 215px	mediawiki/extensions/Popups	master	+37 -16

Customize query in gerrit

Related Objects

Mentioned In: T284355: Settings icon displaced when site language direction is different from content language
Mentioned Here: T249902: Page preview in Minerva show a cut off settings cog
T269336: Preview popups: Replace SVG with clip-path

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Jdlrobson renamed this task from Setting button in article preview interferes to a image to Settings button misplaced in article preview.Mar 8 2021, 5:49 PM

This regression was caused by the clip path change we introduced in T269336 according to git bisect.

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 8 2021, 5:58 PM

ovasileva renamed this task from Settings button misplaced in article preview to Regression: Settings button misplaced in article preview.Mar 8 2021, 6:15 PM

ovasileva set the point value for this task to 5.Mar 8 2021, 6:19 PM

@Nomsterio let me know if you have time to look into this one as well, thanks!

BTW when I click on the setting button, it will open #mw-prefsection-rendering. Would it be possible to add a link to the concrete section? For example, this link referees to the concrete section: #mw-prefsection-editing-discussion. Thanks in advance.

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 8 2021, 10:02 PM

Change 670094 had a related patch set uploaded (by Noam Rosenthal; owner: Noam Rosenthal):
[mediawiki/extensions/Popups@master] Set thumbnail width to 215px

https://gerrit.wikimedia.org/r/670094

gerritbot added a project: Patch-For-Review.Mar 9 2021, 8:21 AM

In T276668#6893861, @Gilles wrote:

@Nomsterio let me know if you have time to look into this one as well, thanks!

Fixed in https://gerrit.wikimedia.org/r/670094

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 9 2021, 4:27 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 10 2021, 11:54 PM

In T276668#6894185, @Patriccck wrote:

BTW when I click on the setting button, it will open #mw-prefsection-rendering. Would it be possible to add a link to the concrete section? For example, this link referees to the concrete section: #mw-prefsection-editing-discussion. Thanks in advance.

Include only one problem per task.

ovasileva raised the priority of this task from Medium to High.Mar 15 2021, 5:26 PM

@Nomsterio - thank you for getting this started! do you have availability to continue working on a fix here?

• Gilles moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.Mar 15 2021, 7:53 PM

In T276668#6914838, @ovasileva wrote:

@Nomsterio - thank you for getting this started! do you have availability to continue working on a fix here?

Yes I'm looking into it.

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 16 2021, 5:17 PM

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 16 2021, 9:36 PM

Jdlrobson updated the task description. (Show Details)Mar 16 2021, 9:43 PM

LGoto reassigned this task from Nomsterio to Jdlrobson.Mar 17 2021, 5:11 PM

LGoto moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

LGoto added a subscriber: Nomsterio.

Patriccck updated the task description. (Show Details)Mar 17 2021, 5:15 PM

Jdlrobson reassigned this task from Jdlrobson to Edtadros.Mar 22 2021, 9:41 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 670094 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Set thumbnail width to 215px

https://gerrit.wikimedia.org/r/670094

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2021, 10:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 22 2021, 11:00 PM

@Jdlrobson I looked at the prod links in the description and I'm able to see the issue with the Richard Genzer preview. Is there a preview in beta that would have been similarly affected so that I can test it? I did some random spot-checking though. I am not sure if this is sufficient without a preview similar to the one that errored in prod.

en beta

Screen Shot 2021-03-24 at 6.43.11 AM.png (270×484 px, 191 KB)

en beta with uselang=he for RTL

Screen Shot 2021-03-24 at 6.42.52 AM.png (290×498 px, 221 KB)

@Edtadros we can use patchdemo to test the Betty Compson case and do some general exploratory testing. I'll set one up and get it to announce the test wiki here....

Hmm.. seems we can't use patchdemo here (it is incompatible with the unique URL structure). This should be reproducable soon on https://en.m.wikipedia.beta.wmflabs.org/wiki/Betty_Compson but not right now (there appears to be an issue with RESTBase)

Test Result - Beta

Status: ❓
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Go to https://en.m.wikipedia.beta.wmflabs.org/wiki/Betty_Compson when hovering over "The Barker" verify the gear is in the right place and not obscured.

Screen Shot 2021-04-01 at 7.24.24 AM.png (628×687 px, 156 KB)

@Jdlrobson this looks like a different issue where the gear is obscured by the faded text box.

Test Result -Prod

Status: ❌ FAIL
Environment: beta/xyzwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: test 1

Go here.
Try to hover over a link "Richard Genzer", you will see an article preview.

Screen Shot 2021-04-01 at 7.38.30 AM.png (416×674 px, 203 KB)

✅ AC2: test 2

Go to https://en.wikipedia.org/wiki/Betty_Compson when hovering over "The Barker"

Screen Shot 2021-04-01 at 7.38.05 AM.png (370×705 px, 203 KB)

❌ AC3: Test 3

Go to https://he.wikipedia.org/wiki/הממלכה_המאוחדת and hover over לונדון

Edtadros updated the task description. (Show Details)Apr 1 2021, 2:46 PM

Edtadros updated the task description. (Show Details)

Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

@ovasileva shall we ficx T249902 while we're here per AC1 ?

Jdlrobson reassigned this task from Jdlrobson to ovasileva.Apr 1 2021, 6:37 PM

In T276668#6966165, @Jdlrobson wrote:

@ovasileva shall we ficx T249902 while we're here per AC1 ?

Sounds good to me, but can we get an estimate for it next week first prior to starting?

@Jdlrobson - What I'm seeing on hewiki, https://he.wikipedia.org/wiki/הממלכה_המאוחדת and hovering over לונדון

Screen Shot 2021-04-14 at 7.24.14 PM.png (670×1 px, 699 KB)

In T276668#6999608, @ovasileva wrote:

@Jdlrobson - What I'm seeing on hewiki, https://he.wikipedia.org/wiki/הממלכה_המאוחדת and hovering over לונדון

Okay, this needs more work.

ovasileva lowered the priority of this task from High to Medium.Apr 19 2021, 5:33 PM

bwang subscribed.Apr 19 2021, 5:33 PM

LGoto assigned this task to bwang.Apr 19 2021, 5:33 PM

LGoto removed bwang as the assignee of this task.

LGoto assigned this task to bwang.

bwang moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 20 2021, 5:07 PM

bwang removed bwang as the assignee of this task.Apr 22 2021, 8:28 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 681452 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Fix setting button placement in article preview

https://gerrit.wikimedia.org/r/681452

gerritbot added a project: Patch-For-Review.Apr 26 2021, 4:09 PM

LGoto assigned this task to Jdrewniak.Apr 26 2021, 5:42 PM

Jdrewniak reassigned this task from Jdrewniak to Edtadros.Apr 29 2021, 5:05 PM

Jdrewniak moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdrewniak subscribed.

Change 681452 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix setting button placement in article preview

https://gerrit.wikimedia.org/r/681452

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 7:11 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 29 2021, 8:00 PM

@Jdrewniak @bwang I wasn't sure what page to test out in beta. From some of the comments, it appeared that the issue was mostly an hewiki issue. So, I spent some time on hebeta and got my wrist slapped for trying to create a page. So here we are. Here is what I am seeing on enbeta.

https://en.wikipedia.beta.wmflabs.org/wiki/Hemigalinae

Screen Shot 2021-05-01 at 10.49.59 AM.png (537×1 px, 306 KB)

I assumed the issue was a RTL issue so I put a uselang=he on it.

Screen Shot 2021-05-01 at 10.49.45 AM.png (556×1 px, 322 KB)

If this is sufficient for Beta testing let me know and I'll move this to the right.

Yes, this is mainly something we want to test on a wiki in a RTL language (doesn't have to be hebrew). @Jdrewniak will have to confirm, but uselang=he might be the closest we can get on the beta cluster. The page preview in your screenshot also looks like the same kind of preview as in the original regression, so the fix seems to be working as far as I can tell.

• Gilles moved this task from Doing: Prio Interrupt to Radar on the Performance-Team board.May 3 2021, 6:31 PM

• Gilles edited projects, added Performance-Team (Radar); removed Performance-Team.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.May 10 2021, 1:28 AM

Jdrewniak reassigned this task from Jdrewniak to Edtadros.May 10 2021, 9:20 AM

Jdrewniak moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Test Result -Prod

Status: ❌ FAIL
Environment: cswiki, enwiki, hewiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

✅ AC1: test 1

Go here.
Try to hover over a link "Richard Genzer", you will see an article preview.

Screen Shot 2021-05-14 at 7.22.34 AM.png (890×1 px, 379 KB)

✅ AC2: test 2

Go to https://en.wikipedia.org/wiki/Betty_Compson when hovering over "The Barker"

Screen Shot 2021-05-14 at 7.23.48 AM.png (890×1 px, 546 KB)

❌ AC3: Test 3

Go to https://he.wikipedia.org/wiki/הממלכה_המאוחדת and hover over לונדון

Screen Shot 2021-05-14 at 7.24.42 AM.png (890×1 px, 491 KB)

Edtadros updated the task description. (Show Details)May 14 2021, 2:29 PM

Hi @Edtadros, I just took a second look at the AC3 on prod, and it seemed to work for me. Does this task still need work? https://jmp.sh/PdhIcyR

@bwang definitely still needs more work:

Screen Shot 2021-06-01 at 11.44.26 AM.png (668×1 px, 611 KB)

This occurs when the site language and content language are different (I've set English in Special:Preferences)

We talked about this in standup and are going to create a new ticket for the above problem.

LGoto reassigned this task from bwang to cjming.Jun 3 2021, 5:04 PM

Tested all 3 cases on prod - looks good!

Screen Shot 2021-06-04 at 3.00.52 PM.png (948×1 px, 470 KB)

Screen Shot 2021-06-04 at 2.59.24 PM.png (715×951 px, 298 KB)

Screen Shot 2021-06-04 at 2.59.04 PM.png (553×865 px, 222 KB)

Considering this ticket resolved and signed off.

cjming closed this task as Resolved.Jun 4 2021, 9:04 PM

Jdlrobson mentioned this in T284355: Settings icon displaced when site language direction is different from content language .Jun 4 2021, 9:56 PM

	F34481012: Screen Shot 2021-06-04 at 2.59.04 PM.png
	Jun 4 2021, 9:04 PM

	F34481014: Screen Shot 2021-06-04 at 3.00.52 PM.png
	Jun 4 2021, 9:04 PM

	F34481013: Screen Shot 2021-06-04 at 2.59.24 PM.png
	Jun 4 2021, 9:04 PM

	F34477471: Screen Shot 2021-06-01 at 11.44.26 AM.png
	Jun 1 2021, 6:44 PM

	F34453979: Screen Shot 2021-05-14 at 7.23.48 AM.png
	May 14 2021, 2:28 PM

	F34453981: Screen Shot 2021-05-14 at 7.24.42 AM.png
	May 14 2021, 2:28 PM

	F34453977: Screen Shot 2021-05-14 at 7.22.34 AM.png
	May 14 2021, 2:28 PM

	F34436614: Screen Shot 2021-05-01 at 10.49.45 AM.png
	May 1 2021, 5:55 PM

Regression: Settings button misplaced in article previewClosed, ResolvedPublic5 Estimated Story PointsActions

Description

QA

QA Results - Beta

QA Results - Prod

QA Results - Prod

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result -Prod

QA Steps

Test Result -Prod

QA Steps

Regression: Settings button misplaced in article preview
Closed, ResolvedPublic5 Estimated Story Points
Actions