Page MenuHomePhabricator

ORES tests failing: Field 'rc_timestamp' doesn't have a default value
Closed, ResolvedPublic

Description

Eg https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/669350

05:29:06 There were 7 errors:
05:29:06 
05:29:06 1) ORES\Tests\SqlScoreStorageTest::testStoreScoresCleanupOldScores
05:29:06 Wikimedia\Rdbms\DBQueryError: Error 1364: Field 'rc_timestamp' doesn't have a default value (localhost:/workspace/db/quibble-mysql-d8et5uib/socket)
05:29:06 Function: ORES\Tests\SqlScoreStorageTest::testStoreScoresCleanupOldScores
05:29:06 Query: INSERT INTO `unittest_recentchanges` (rc_this_oldid,rc_cur_id,rc_last_oldid,rc_comment_id,rc_actor) VALUES ('567',3,'425',1,32)
05:29:06 
05:29:06 
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:1703
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:1687
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:1662
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:1231
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:2349
05:29:06 /workspace/src/includes/libs/rdbms/database/Database.php:2329
05:29:06 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:68
05:29:06 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:369
05:29:06 /workspace/src/extensions/ORES/tests/phpunit/includes/Storage/SqlScoreStorageTest.php:204
05:29:06 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:449
05:29:06 /workspace/src/maintenance/doMaintenance.php:112
05:29:06 === Logs generated by test case
05:29:06 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
05:29:06 [localisation] [debug] LocalisationCache using store LCStoreNull []
05:29:06 [localisation] [debug] LocalisationCache using store LCStoreNull []
05:29:06 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
05:29:06 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
05:29:06 [localisation] [debug] LocalisationCache using store LCStoreNull []
05:29:06 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
05:29:06 ===
...

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Also blocking merges to some other extensions, like PageTriage: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/669390

Caused by 4a6d4baaed071a0952e91eb9133c094adb6829d6 (part of T230428 and T42626) which included "Drop default of rc_timestamp" for MySQL and Sqlite

Change 669605 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/ORES@master] Provide timestamp when inserting rc data

https://gerrit.wikimedia.org/r/669605

Change 669605 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Provide timestamp when inserting rc data

https://gerrit.wikimedia.org/r/669605

Ladsgroup assigned this task to Ammarpad.