TypeError: title is undefined
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	kostajh
	Mar 8 2021, 9:38 AM

Description

Error

MediaWiki version: 1.36.0-wmf.33

message

TypeError: title is undefined

exception.trace

n/a

Impact

Help panel fails to load if the user does not have an assigned mentor

Notes

I think this resulted from code changed in T273118: Help panel: Remove dependency on Help Desk title existing and/or T275908: Scale: default to mentorship questions from help panel, where we started defaulting the help panel question to the mentor page. If the user doesn't have a mentor assigned (rare, but can happen) then this code in HelpPanelProcessDialog.js errors:

if ( this.askSource === 'mentor-homepage' ) {
    mentorName = mw.config.get( 'GEHomepageMentorshipMentorName' );
} else { // mentor-helppanel
    mentorName = mw.config.get( 'wgGEHelpPanelMentorData' ).name;
}
mentorTalkLinkText = mw.message(
    'growthexperiments-homepage-mentorship-questionreview-header-mentor-talk-link-text',
    mentorName, userName ).text();
$mentorTalkLink = $( '<a>' )
    .attr( {
        href: mw.Title.newFromText( mentorName, 3 ).getUrl(),
        target: '_blank',
            'data-link-id': 'mentor-talk'
    } )
    .text( mentorTalkLinkText );

Logstash filtered to this error: https://logstash.wikimedia.org/goto/c1142d1eadd619a81be775b68797bb48

Details

Request URL: https://th.wikipedia.org/w/load.php?

Related Objects

Mentioned In: T276966: GrowthExperiments help error : TypeError: title is undefined, Uncaught TypeError: Cannot read property 'replace' of undefined
T273782: Help desk errors out when GEHelpPanelAskMentor is true and there are no mentors available
T275908: Scale: default to mentorship questions from help panel
Mentioned Here: T273118: Help panel: Remove dependency on Help Desk title existing
T275908: Scale: default to mentorship questions from help panel

Event Timeline

kostajh created this task.Mar 8 2021, 9:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2021, 9:38 AM

T275908: Scale: default to mentorship questions from help panel was not yet deployed, we have a local override in operations/mediawiki-config and https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/667529 was not yet merged.

kostajh triaged this task as Medium priority.Mar 8 2021, 11:08 AM

kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Umherirrender added a project: JavaScript.Mar 8 2021, 4:42 PM

kostajh mentioned this in T275908: Scale: default to mentorship questions from help panel.Mar 9 2021, 7:50 AM

kostajh mentioned this in T273782: Help desk errors out when GEHelpPanelAskMentor is true and there are no mentors available.Mar 9 2021, 7:54 AM

kostajh mentioned this in T276966: GrowthExperiments help error : TypeError: title is undefined, Uncaught TypeError: Cannot read property 'replace' of undefined.Mar 9 2021, 7:57 PM

Krinkle added a project: GrowthExperiments.Mar 9 2021, 11:41 PM

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.

Krinkle updated the task description. (Show Details)Mar 10 2021, 7:39 PM

Krinkle edited Stack Trace. (Show Details)

kostajh claimed this task.Mar 15 2021, 12:13 PM

kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh merged a task: T276966: GrowthExperiments help error : TypeError: title is undefined, Uncaught TypeError: Cannot read property 'replace' of undefined.

kostajh added a subscriber: Jdlrobson.

This problem should have been solved by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/670021 which was backported to wmf.33 and wmf.34. But for some reason this code is not actually being served in production, and the wmf.32 version of the erroring JS was being served.

@Urbanecm_WMF updated the submodule for GrowthExperiments in the wmf.34 release branch and synced that.