Page MenuHomePhabricator
Create Task
Maniphest T276783

"Page should be undoable" selenium test is flaky
Open, Needs TriagePublic
Actions

Description

Seen this fail twice today, out of maybe a dozen merge attempts:

13:20:56 [0-1] Error in "Page should be undoable"
13:20:56 Can't call getText on element with selector "#mw-content-text .mw-parser-output" because element wasn't found
13:20:56 [0-1] FAILED in chrome - /tests/selenium/specs/page.js

The screenshot suggests this is a timing issue, checking the page content before the page finished saving:

Page-should-be-undoable.png (1×1 px, 154 KB)

The test was added in rMW32c36f0e7303: selenium: undo page which was quite a while ago, not sure what changed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
selenium: Disable flaky undoable page testmediawiki/coremaster+1 -1
Suppress VisualEditor welcome dialog in undo Selenium testmediawiki/coremaster+7 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT291254 Find flaky Selenium tests
 OpenNoneT276783 "Page should be undoable" selenium test is flaky

Event Timeline

Tgr created this task.Mar 8 2021, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2021, 12:45 PM
Tgr updated the task description. (Show Details)Mar 8 2021, 12:51 PM
zeljkofilipin subscribed.Mar 8 2021, 1:41 PM

It seems to me that for some reason welcome to testwiki popup wasn't disabled, and that caused the failure.

zeljkofilipin claimed this task.Mar 8 2021, 4:24 PM
zeljkofilipin triaged this task as Medium priority.
zeljkofilipin added projects: User-zeljkofilipin, Quality-and-Test-Engineering-Team.
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
Daimona raised the priority of this task from Medium to Unbreak Now!.Mar 8 2021, 4:46 PM
Daimona added a project: ci-test-error (WMF-deployed Build Failure).
Daimona subscribed.

This has caused r669091 for AbuseFilter to fail gate-and-submit twice today.

Breaking other repos -> UBN

zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 8 2021, 5:22 PM

I'm unlikely to have the time to take a look today, de-assigning for now.

zeljkofilipin moved this task from Deep work 🌊 to Quarter 👔 on the User-zeljkofilipin board.Mar 8 2021, 5:23 PM
RhinosF1 subscribed.Mar 8 2021, 6:08 PM
Nikerabbit awarded a token.Mar 9 2021, 12:20 PM
Nikerabbit subscribed.
gerritbot added a comment.Mar 9 2021, 1:51 PM

Change 670173 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Suppress VisualEditor welcome dialog in undo Selenium test

https://gerrit.wikimedia.org/r/670173

gerritbot added a project: Patch-For-Review.Mar 9 2021, 1:51 PM
Daimona merged a task: T276965: Frequent MediaWiki core browser test failures: "Page should be undoable" .Mar 9 2021, 5:14 PM
Daimona added a subscriber: Lucas_Werkmeister_WMDE.
gerritbot added a comment.Mar 9 2021, 7:46 PM

Change 670173 merged by jenkins-bot:
[mediawiki/core@master] Suppress VisualEditor welcome dialog in undo Selenium test

https://gerrit.wikimedia.org/r/670173

matmarex closed this task as Resolved.Mar 9 2021, 7:57 PM
matmarex subscribed.

Hopefully fixed?

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 9 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 8:10 PM
kostajh subscribed.Mar 10 2021, 10:22 PM

Seen again just now in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-selenium-docker/36269/console https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/670225

kostajh reopened this task as Open.Mar 10 2021, 10:22 PM

This time the error is:

23:14:18 Node is either not visible or not an HTMLElement

image.png (1×1 px, 167 KB)

matmarex unsubscribed.Mar 10 2021, 10:46 PM
gerritbot added a comment.Mar 11 2021, 10:55 AM

Change 670787 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/core@master] selenium: Disable flaky undoable page test

https://gerrit.wikimedia.org/r/670787

gerritbot added a project: Patch-For-Review.Mar 11 2021, 10:55 AM
kostajh added a comment.Mar 11 2021, 10:56 AM

Another error screenshot:

image.png (828×1 px, 94 KB)

This keeps breaking in GrowthExperiments repo patches, I'm not sure if it's seen elsewhere. I've pushed a patch to disable the test.

gerritbot added a comment.Mar 11 2021, 11:24 AM

Change 670787 merged by jenkins-bot:
[mediawiki/core@master] selenium: Disable flaky undoable page test

https://gerrit.wikimedia.org/r/670787

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2021, 12:10 PM
DannyS712 merged a task: T277614: Flaky selenium test: Error in "Page should be undoable": Can't call getText on element ....Mar 17 2021, 12:56 AM
DannyS712 added a subscriber: ori.
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.Mar 25 2021, 10:06 PM
Jdforrester-WMF subscribed.

Test is disabled, so no longer UBN.

zeljkofilipin raised the priority of this task from High to Needs Triage.Sep 17 2021, 9:35 AM
zeljkofilipin removed a project: Quality-and-Test-Engineering-Team.
zeljkofilipin added a parent task: T291254: Find flaky Selenium tests.Oct 7 2021, 11:40 AM
zeljkofilipin moved this task from Quarter 👔 to Backlog 🪒 on the User-zeljkofilipin board.
zeljkofilipin removed a project: User-zeljkofilipin.Oct 7 2021, 6:03 PM
TheresNoTime removed a subscriber: RhinosF1.Dec 15 2022, 11:36 PM
Universal_Omega subscribed.Jan 17 2023, 10:26 PM
zeljkofilipin added a project: Testing Support.Mar 24 2025, 6:14 PM
zeljkofilipin removed a project: MediaWiki-Core-Tests.Mar 24 2025, 6:31 PM
zeljkofilipin removed a project: Browser-Tests.Mar 24 2025, 6:48 PM
SDunlap added a project: Browser Test Platform.Mon, Nov 17, 9:38 PM
zeljkofilipin removed a project: Testing Support.Thu, Nov 20, 4:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits