Page MenuHomePhabricator

Use bounded context use cases for actions that change donations in Fundraising Operation Center
Closed, ResolvedPublic3 Estimated Story Points

Description

Change application/controller/Backend/Ajax/ListController.php to use the bounded context actions for changing the state of donations (un)moderation and (un)deletion instead of DonationStatusUpdateService.

Remove "unlock" functionality:

  • unlockAction from application/controller/Backend/Ajax/ListController.php
  • the markup for generating the icon/action in templates/donation_list.twig
  • the lock icon image files
  • Function unlockDataset in res/js/donationlist.js
  • unlockForUpdate from app/model/Donation.php.

Background information why we no longer need the "unlock" function: extending the expiry of the update token to allow for modification is no longer needed, because that was used for failed payments. Since 2016 payment code no longer checks the expiry date of the update token, only if the token matches.

Delete src/DonationStatusUpdateService.php and its test.

Remove getRecoveredStatus code from app/model/Donation.php.

Splitting or renaming the ListController (which is really a DonationController) is optional.

Event Timeline

kai.nissen set the point value for this task to 5.Apr 9 2021, 1:46 PM
kai.nissen changed the point value for this task from 5 to 3.May 10 2021, 10:19 AM