| gengh | |
| Mar 8 2021, 4:11 PM |
| F34599761: Screenshot from 2021-08-18 11-25-15.png | |
| Aug 18 2021, 10:33 AM |
| F34599760: Screenshot from 2021-08-18 11-25-37.png | |
| Aug 18 2021, 10:33 AM |
| F34599759: Screenshot from 2021-08-18 11-25-55.png | |
| Aug 18 2021, 10:33 AM |
When we represent a ZReference in the built-in component ZReference.vue, we show the ZObjectSelector to allow the user to find and select an object.
However, if this ZReference is the value of a key that is known to accept a given type, the ZObjectSelector should only search/offer/select ZObjects of that given type.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Enforce type of references to the expected type for the key | mediawiki/extensions/WikiLambda | master | +3 -2 |
Checking again. @gengh @Jdforrester-WMF @DVrandecic do we have a current example of this? Want to make sure it's still valid.
Still valid, I believe.
For example, say you create a new ZObject in the special page and you choose to create an object of type Z4 (Type). The key Z4K3 is a validator (Z8/Function) and by default it selects literal mode so we can write down the Z8 directly. If we change the mode and we select Reference, we see the ZReference component, which renders a ZObjectSelector. Even though we know that the only type of ZObject that can be selected in here must be a Z8 (because it's the implicit type of Z4K3), the ZObjectSelector allows us to select any kind of ZObject.
The ZObjectSelector has a prop which is type that limits the types of objects that can be requested and selected, and this prop is empty. I believe that in a case like this (where the type of object is known) it could be leveraged.
Change 714777 had a related patch set uploaded (by Lindsay Wardell; author: Lindsay Wardell):
[mediawiki/extensions/WikiLambda@master] Enforce type of references to the expected type for the key
Change 714777 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Enforce type of references to the expected type for the key