International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Mar 8 2021, 4:16 PM

Description

TypeError: this.banner is undefined at value https://de.wikipedia.org/wiki/Arget_(Sauerlach) line 137 > injectedScript:1:52424

628 errors starting about 8hrs ago

https://meta.wikimedia.org/w/index.php?title=Special:BannerLoader&campaign=InternationalWomensDayMonth&banner=InternationalWomensMonth&uselang=en&debug=false

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.03.08?id=D8uaEngBfVMx58vqFsqV

500 errors in last 12hrs = unbreak now.

This error only seems to impacts german wikipedia

A second related error TypeError: undefined is not an object (evaluating 'this.banner.style') https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.03.08?id=BKaXEngBA6MeBtBq6T4s

A third error "Uncaught SyntaxError: Unexpected identifier" impacts english wikipedia, originating from the same banner URI

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.03.08?id=GvefEngBg_6mGHGhRNHQ

Related Objects

Mentioned In: T274804: Review and integrate external banner development work
T276826: Fundraising banner with inline SVG triggers `Uncaught TypeError: node.className.replace is not a function` for layout shift due to SVGAnimatedString className attribute.

Event Timeline

Jdlrobson created this task.Mar 8 2021, 4:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2021, 4:16 PM

Jdlrobson triaged this task as Unbreak Now! priority.Mar 8 2021, 4:16 PM

Restricted Application added a subscriber: Pcoombe. · View Herald TranscriptMar 8 2021, 4:16 PM

Jdlrobson renamed this task from International Woman' Day banner has JS error (TypeError: this.banner is undefined) to International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined).Mar 8 2021, 4:17 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson mentioned this in T276826: Fundraising banner with inline SVG triggers `Uncaught TypeError: node.className.replace is not a function` for layout shift due to SVGAnimatedString className attribute..Mar 8 2021, 4:22 PM

Jdlrobson updated the task description. (Show Details)Mar 8 2021, 4:25 PM

RhinosF1 subscribed.Mar 8 2021, 4:26 PM

Umherirrender added a project: JavaScript.Mar 8 2021, 4:41 PM

• jbolorinos-ctr subscribed.Mar 8 2021, 5:37 PM

• DStrine moved this task from Triage to Blocked or not fr-tech on the Fundraising-Backlog board.Mar 8 2021, 6:26 PM

This is not a fundraising banner. Adding Wikimedia-CentralNotice-Administration which I believe is the most appropriate project for these community banner content issues (?) and pinging @Seddon who created this banner.

I'm fairly sure the errors are cause by this banner campaign which is contemporaneous with the errors occurring.

If I had to guess firstly there seem to errors with this banner this banner. @kai.nissen & @DerHexer

The errors may also be due to some sort of incompatibility here with campaign fallback which is what is resulting in the error associated with International Woman's Day

• Jseddon added a project: MediaWiki-extensions-CentralNotice.Mar 8 2021, 8:31 PM

Campaign is disabled for now.

kai.nissen mentioned this in T274804: Review and integrate external banner development work.Mar 8 2021, 9:58 PM

Screen Shot 2021-03-08 at 2.36.45 PM.png (948×2 px, 305 KB)

https://logstash.wikimedia.org/goto/e8aca41bef51e3c8a0a37b18f61da311

Thanks for silencing the error for now.

Banners should be fixed. I re-enabled to campaign and will keep an eye on the error logs.

LGTM. I'm seeing 3 errors in the last 12hrs :)

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Jun 23 2022, 4:06 PM

	F34146407: Screen Shot 2021-03-08 at 2.36.45 PM.png
	Mar 8 2021, 10:37 PM

	F34145734: Screen Shot 2021-03-08 at 8.13.52 AM.png
	Mar 8 2021, 4:16 PM

International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined)Closed, ResolvedPublicActions

Description

Related Objects

Event Timeline

International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined)
Closed, ResolvedPublic
Actions