Page MenuHomePhabricator

International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined)
Closed, ResolvedPublic


TypeError: this.banner is undefined at value line 137 > injectedScript:1:52424

628 errors starting about 8hrs ago

Screen Shot 2021-03-08 at 8.13.52 AM.png (322×2 px, 59 KB)*/logstash-2021.03.08?id=D8uaEngBfVMx58vqFsqV

500 errors in last 12hrs = unbreak now.

This error only seems to impacts german wikipedia

  • A third error "Uncaught SyntaxError: Unexpected identifier" impacts english wikipedia, originating from the same banner URI*/logstash-2021.03.08?id=GvefEngBg_6mGHGhRNHQ

Event Timeline

Jdlrobson triaged this task as Unbreak Now! priority.Mar 8 2021, 4:16 PM
Jdlrobson renamed this task from International Woman' Day banner has JS error (TypeError: this.banner is undefined) to International Woman' Day banner on German Wikipedia has JS error (TypeError: this.banner is undefined).Mar 8 2021, 4:17 PM
Jdlrobson updated the task description. (Show Details)
Pcoombe added a subscriber: Seddon.

This is not a fundraising banner. Adding Wikimedia-CentralNotice-Administration which I believe is the most appropriate project for these community banner content issues (?) and pinging @Seddon who created this banner.

I'm fairly sure the errors are cause by this banner campaign which is contemporaneous with the errors occurring.

If I had to guess firstly there seem to errors with this banner this banner. @kai.nissen & @DerHexer

The errors may also be due to some sort of incompatibility here with campaign fallback which is what is resulting in the error associated with International Woman's Day

Jdlrobson lowered the priority of this task from Unbreak Now! to Needs Triage.Mar 8 2021, 10:37 PM

Banners should be fixed. I re-enabled to campaign and will keep an eye on the error logs.

Jdlrobson claimed this task.

LGTM. I'm seeing 3 errors in the last 12hrs :)